Undo changes from #17 and fix via tileset change #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Though not mentioned in the initial commit messages, this reverts the fix done for issue #17 where the bottom of a cropped map was cut off. The issue seen in #17 is nothing to do with a cropped map; it's easily reproducible (in a much more severe form) with a world that only contains chunk (0,0) without even considering a crop. This reverts commit 3a1bb47. This reverts commit 8be3b23. This reverts commit 291a660. Fixes #90 Change-Id: I02698911647cf829096f20aecbfa01bb8fd375ca
This increases the amount of additional y space that chunks need to render their full height Fixes #17 properly Change-Id: I28695ff97417ac3beecf015b000c33c356449c34
This was
linked to
issues
May 20, 2025
Collaborator
Author
|
Apparently this has also broken tests. A quick look at the broken tests makes me think that the expected values of the tests are depending on the shorter chunk size, and that we probably just need to update the tests now too, since a different set of dirty tiles will be returned given the taller chunks. I'll look at this later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#17 (comment) has the gory details here.
I'd like to wait for verification before this is merged - draftifying while we wait.