-
Notifications
You must be signed in to change notification settings - Fork 329
Add biomeTag recipe condition #4419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 1.20.1
Are you sure you want to change the base?
Conversation
Spicierspace153
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
jurrejelle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you make a docs/content/Modpacks/changes/v7.4.1.md following the format of the previous ones, and add a line that this is a new recipe condition? thanks :)
jurrejelle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, this could probably be part of the existing Biome RecipeCondition? No need to make a seperate condition for it I feel
|
I added the documentation file, but I wasn't able to get it working with just BiomeCondition when I tried, since that uses a different type + with KubeJS it wouldn't accept using a "#" symbol in the string, as it threw an error. BiomeCondition doesn't take biome tags. |
|
well yeah you need to change it so it does accept biome tags |
What
This PR adds a biomeTag condition for recipes so that they can require a specific biome tag to run. This allows you to, for instance, make a recipe work in any ocean biome. This can be quite useful for packdevs. I made this PR because my own pack needed this functionality, which was missing from GT.
#4412
Implementation Details
This PR creates a new RecipeCondition called BiomeTagCondition, as well as KubeJS support.
Outcome
This PR resolves #4412 by adding a biome tag recipe condition.