Skip to content

Conversation

@chloecat34
Copy link

What

This PR adds a biomeTag condition for recipes so that they can require a specific biome tag to run. This allows you to, for instance, make a recipe work in any ocean biome. This can be quite useful for packdevs. I made this PR because my own pack needed this functionality, which was missing from GT.
#4412

Implementation Details

This PR creates a new RecipeCondition called BiomeTagCondition, as well as KubeJS support.

Outcome

This PR resolves #4412 by adding a biome tag recipe condition.

@chloecat34 chloecat34 requested a review from a team as a code owner January 3, 2026 23:44
@github-actions github-actions bot added the 1.20.1 label Jan 3, 2026
@TarLaboratories TarLaboratories added type: feature New feature or request bundled for a 0.X.0 Update Release: Major - 0.X.0 Releases focused on Content, changes to gameplay; While maintaining mostly API stability. labels Jan 4, 2026
@Spicierspace153 Spicierspace153 changed the title Added biomeTag recipe condition Add biomeTag recipe condition Jan 4, 2026
Copy link
Contributor

@Spicierspace153 Spicierspace153 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Spicierspace153 Spicierspace153 added Release: Patch - 0.0.X Smaller changes that either are bug fixes or very minor tweaks. and removed Release: Major - 0.X.0 Releases focused on Content, changes to gameplay; While maintaining mostly API stability. labels Jan 4, 2026
Copy link
Contributor

@jurrejelle jurrejelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make a docs/content/Modpacks/changes/v7.4.1.md following the format of the previous ones, and add a line that this is a new recipe condition? thanks :)

Copy link
Contributor

@jurrejelle jurrejelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this could probably be part of the existing Biome RecipeCondition? No need to make a seperate condition for it I feel

@chloecat34
Copy link
Author

I added the documentation file, but I wasn't able to get it working with just BiomeCondition when I tried, since that uses a different type + with KubeJS it wouldn't accept using a "#" symbol in the string, as it threw an error. BiomeCondition doesn't take biome tags.

@screret
Copy link
Contributor

screret commented Jan 5, 2026

well yeah you need to change it so it does accept biome tags
first of all, you need to use a HolderSet<Biome> instead of a ResourceKey<Biome> for the field and RegistryCodecs.homogenousList(Registries.BIOME) instead of ResourceKey.codec(Registries.BIOME) for the codec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.20.1 Release: Patch - 0.0.X Smaller changes that either are bug fixes or very minor tweaks. type: feature New feature or request bundled for a 0.X.0 Update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ability to use biome tags for biome conditions for custom recipes

5 participants