Fix kubejs namespaces #4414
Open
Fix kubejs namespaces #4414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reabstraction
added
Release: Major - 0.X.0
Contributor
|
While this works, you are locking people out of using a different namespace if they wanted to. |
Contributor
|
Yee we discussed that in dev-internals, this won't be merged as is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Updates the builders to forcibly use GTCEu namespaces
Implementation Details
All builders now use
super(GTCEu.id(id.getPath()))as opposed tosuper(id)Outcome
Fixes random issues caused by using KubeJS namespaces