Add recipes for netherite tools #4368
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reabstraction
requested changes
Dec 23, 2025
src/main/java/com/gregtechceu/gtceu/data/recipe/generated/ToolRecipeHandler.java
Show resolved
Hide resolved
Reabstraction
added
the
Release: Major - 0.X.0
Contributor
Author
|
Drafting because vanilla smithing copies all NBT from input stack to output stack. Since our tool attributes are stored via NBT, this means that it keeps the same stats from diamond tools instead of the new ones |
Thanks screret
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds diamond tool + netherite template + netherite ingot as a smithing recipe for all GTToolTypes
Implementation Details
Since vanilla's smithing transform recipe copies all NBT from input to output item, smithed GT tools would keep their old stats, since we apply them using NBT.
I've implemented a mixin to check if the crafted item is an IGTTool. If so, it removes the
GT.Tooltag and copies it over from a new tool stack. This should keep compat with any other mods doing funky stuff withSmithingTransformRecipeAlso added helpers for smithing transform recipes to VanillaRecipeHelper
Outcome
Netherite tools are now obtainable :hapybapycat:
Additional Information
Potential Compatibility Issues
Hopefully none!