Spoilage #3874

TarLaboratories · 2025-09-07T11:37:16Z

What

Spoilage yay!
Added API to modify item outputs and read item inputs in recipe modifiers.
Also made an event that fires just before a machine is registered to allow modifying it's parameters from addons (most notably add recipe modifiers)

Implementation Details

Stores the creation tick of a spoilable item in its nbt, thus bypassing the need to actively tick it.
Should be noted that the item has to be updated at least once after it finished crafting for it to start spoiling (done by updating items inserted into CustomItemStackHandler)
Basically everything is done via a mixin into ItemStack lols
Doesn't actually make any items spoilable, only adds the functionality to do so.

Outcome

GLEBA

… lols

jurrejelle

Very quick review before I have to go do other things, these are my initial thoughts

jurrejelle · 2025-09-07T13:32:17Z

src/main/java/com/gregtechceu/gtceu/core/mixins/ItemStackMixin.java

+    @Inject(at = @At("HEAD"), method = "isSameItemSameTags", cancellable = true)
+    private static void mergeSpoilables(ItemStack stack, ItemStack other, CallbackInfoReturnable<Boolean> cir) {
+        CompoundTag tag1 = stack.getTagElement("GTCEu_spoilable");
+        CompoundTag tag2 = other.getTagElement("GTCEu_spoilable");
+        boolean isSameItem = ItemStack.isSameItem(stack, other) && stack.areCapsCompatible(other);
+        if (tag1 != null && tag2 != null) {
+            long tick1 = tag1.getLong("creation_tick");
+            long tick2 = tag2.getLong("creation_tick");
+            if (tick1 != tick2) {
+                long avg = (tick1 * stack.getCount() + tick2 * other.getCount()) /
+                        (stack.getCount() + other.getCount());
+                tag1.putLong("creation_tick", avg);
+                tag2.putLong("creation_tick", avg);
+            }
+        }
+        cir.setReturnValue(isSameItem && Objects.equals(stack.getTag(), other.getTag()));
+        cir.cancel();
+    }


Why is this done in isSameItemSameTags? Now, when we e.g. compare two itemstacks for recipe checking but the recipe can't run, it will still assign the average spoil value

To be fair, it's very difficult to know when to merge spoilability status and items don't really have a "merge" function. I'm not sure how we would implement this

src/main/resources/gtceu.mixins.json

…ess of inputs

jurrejelle · 2025-09-07T19:52:58Z

Some thoughts I had laid out in the discord, ramble style, that I'd like to document here:

The thing with isItemStackEqual being used as a "merge" check when there might be a case that we're just checking without merging, although I have no clue how to solve that, any ideas welcome
The fact that we have to deeply modify GTRecipe and NotifiableItemStackHandler means our API isn't flexible enough to do these things without. Ideally, when implementing content features, we setup API and then use said API instead of messing with internals. Probably this can be done as a RecipeModifier and then we add API to attach to existing machines? then use a new or existing forge event to let users modify all machines to attach the new RecipeModifier? More input needed. But we definitely should do / be able to do this with public API, otherwise we should improve the API until we can.
The fact that when things spoil, the item just gets turned in the spot. Gameplay wise you'd hope it'd get put somewhere else like in the output bus, or at least it's possible to extract them (which is impossible with input busses since the items are inaccessable)
I'm a little worried at the overhead of checking/updating the state at each of the following: method = { "getItem", "getCount", "getTag", "getOrCreateTag", "getTagElement", "getOrCreateTagElement","getItemHolder" }. Maybe we can profile that or have others look at the method when reviewing
(tiny thought) Injecting into ItemStack this heavily might break compatibility with other mods, not 100% sure, I'm not super well known on mixins
With how many internal methods this touches I would not be comfortable having this in this release cycle without it being in testing / snapshot for a while, although that might be mitigated with the "testing release" that we're planning. More input needed by others too

docs/content/Modpacks/Other-Topics/Spoilage.md

src/main/java/com/gregtechceu/gtceu/common/item/SpoilableBehaviour.java

src/main/java/com/gregtechceu/gtceu/api/item/ISpoilableItemStackExtension.java

src/main/java/com/gregtechceu/gtceu/core/mixins/ItemStackMixin.java

Co-authored-by: screret <[email protected]>

jurrejelle

Some initial questions/notes. Maybe also make an v8.0.0 change docs where you mention you added spoilage and link here, see gustavo's sync PR for how to do that.

jurrejelle · 2026-01-03T14:18:30Z

docs/content/Modpacks/Other-Topics/Spoilage.md

+- A block and an item handler (contains `Level`, `BlockPos`, `IItemHandler` and an `int` slot, that may be `-1`)
+- An entity, usually a player (contains `Entity` and an `int` slot, that may be `-1`)
+


What does the int slot represent?

The slot of the item in the IItemHandler

Maybe consider adding that to the docs then

jurrejelle · 2026-01-03T14:19:52Z

docs/content/Modpacks/Other-Topics/Spoilage.md

+- `.result(Function<ItemStack, ItemStack>)`
+    used to specify the resulting stack that may depend on the original stack
+- `.result(EntityType<? extends Mob>)`
+    used to specify the mob into which the item will spoil (it can still spoil into an item as well, but it has to be specified first)


What is "it" here? Does the ItemStack have to be specified first, or the EntityType?

The stack has to be specified first, ig i should make that more clear

jurrejelle · 2026-01-03T14:24:24Z

src/main/java/com/gregtechceu/gtceu/api/gui/widget/PhantomSlotWidget.java

+                ItemStack carried = gui.getModularUIContainer().getCarried().copy();
+                ISpoilableItem spoilable = GTCapabilityHelper.getSpoilable(carried);
+                if (spoilable != null) spoilable.freezeSpoiling();
+                slotReference.set(carried);


Will need to eventually do stuff like this in MUI2 in GTM too when that's implemented

jurrejelle · 2026-01-03T14:33:22Z

src/main/java/com/gregtechceu/gtceu/api/registry/registrate/MachineBuilder.java

+    public MachineBuilder<DEFINITION> addRecipeModifier(RecipeModifier recipeModifier) {
+        if (this.recipeModifier instanceof RecipeModifierList list) {
+            this.recipeModifier = new RecipeModifierList(ArrayUtils.add(list.getModifiers(), recipeModifier));
+        } else {
+            this.recipeModifier = new RecipeModifierList(this.recipeModifier, recipeModifier);
+        }
+        return this;
+    }
+


Needs a similar method in MultiblockMachineBuilder since the return type of that is different

jurrejelle · 2026-01-03T14:38:50Z

src/main/java/com/gregtechceu/gtceu/core/mixins/ItemStackMixin.java

+import javax.annotation.Nullable;
+
+@Mixin(ItemStack.class)
+public abstract class ItemStackMixin implements ISpoilableItemStackExtension {


Not really an actionable point, but having 13 mixins into ItemStack for spoilage is making my skin crawl and I do not look forward to all the conflicts and problems this will cause with minecraft let alone other mods

well it shouldn't cause any conflicts with anything really, since all it does is call the upsate function

jurrejelle · 2026-01-03T14:43:01Z

src/main/java/com/gregtechceu/gtceu/common/data/GTRecipeModifiers.java

+                ISpoilableItem spoilable = GTCapabilityHelper.getSpoilable(stack);
+                if (spoilable != null && spoilable.shouldSpoil() && spoilableCount > 0) {
+                    double spoiled = spoilProgress / spoilableCount;
+                    spoilable.setTicksUntilSpoiled((long) (spoiled * spoilable.getSpoilTicks()));
+                }


Early return if stack doesn't have a spoilable higher up in the function maybe?

Also what happens if you start a recipe with spoiled inputs + outputs, shut down the world, start it up again? Does it just make a full freshness item?

TarLaboratories added 5 commits September 6, 2025 21:47

spoilage lols (idk maybe works)

9504b0c

yay it works

ec7e1af

tooltip and bar

7c0c129

bar color and different spoilage timer stacking

d0d8903

made mv sodium battery not spoil into dirt lols

8b1a927

TarLaboratories requested a review from a team as a code owner September 7, 2025 11:37

TarLaboratories added type: feature New feature or request bundled for a 0.X.0 Update 1.20.1 Release: Major - 0.X.0 Releases focused on Content, changes to gameplay; While maintaining mostly API stability. labels Sep 7, 2025

github-actions bot added the Tests: Failed Game Tests have failed on this PR label Sep 7, 2025

TarLaboratories and others added 3 commits September 7, 2025 14:41

Merge branch '1.20.1' into tar/spoilage

134112c

idk

5971ae6

im so dumb i wrote the wrong thing in the isSameItemSameTags function…

98e51a1

… lols

github-actions bot added Tests: Passed Game Tests have passed on this PR and removed Tests: Failed Game Tests have failed on this PR labels Sep 7, 2025

jurrejelle reviewed Sep 7, 2025

View reviewed changes

TarLaboratories added 7 commits September 7, 2025 17:07

formatting

40dc1e2

additional check before averaging

7b3b983

keep spoiling progress between recipe inputs and outputs

a6f8257

added an option to make a recipe output a fully fresh product regardl…

004a07c

…ess of inputs

fixes

ad443b0

oops left mv battery spoilable

408cb2b

april fools :)

14a282f

TarLaboratories and others added 2 commits September 8, 2025 08:59

Merge branch '1.20.1' into tar/spoilage

328fe42

made SpoilableBehaviour more flexible

0eb0a6c

jurrejelle added Release: API - X.0.0 Major Breaking Refactors that MUST be in a API-Breaking Release and removed Release: Major - 0.X.0 Releases focused on Content, changes to gameplay; While maintaining mostly API stability. labels Sep 8, 2025

TarLaboratories added 2 commits September 8, 2025 12:48

added the ability to attach SpoilableBehaviour to any item

acad6e6

trollololol

0729962

screret suggested changes Nov 16, 2025

View reviewed changes

TarLaboratories and others added 2 commits November 17, 2025 10:36

apply suggestions

0874922

Co-authored-by: screret <[email protected]>

remove unsafe cast and rename ISpoilableItemStackMixin

bca2eb6

github-actions bot added Tests: Failed Game Tests have failed on this PR and removed Tests: Passed Game Tests have passed on this PR labels Nov 17, 2025

TarLaboratories and others added 5 commits November 17, 2025 10:43

start names of mixin methods with gtceu$

fb372b6

move suppressWarnings

3ed8432

readd unsafe cast cause doesn't compile

a08edb5

revert interfaces.json change

22520ba

Merge branch '1.20.1' into tar/spoilage

9d5fda4

github-actions bot added Tests: Passed Game Tests have passed on this PR and removed Tests: Failed Game Tests have failed on this PR labels Nov 17, 2025

TarLaboratories changed the base branch from 1.20.1 to 1.20.1-v8.0.0 December 13, 2025 05:42

TarLaboratories and others added 6 commits December 28, 2025 17:41

spoiling into entities

85351e8

this is probably compatible with most blocks

4fdeabd

docs

4f0bb95

more docs

4dd7b51

more tests

32aadd6

Merge branch '1.20.1-v8.0.0' into tar/spoilage

591b30c

github-actions bot added Tests: Failed Game Tests have failed on this PR and removed Tests: Passed Game Tests have passed on this PR labels Dec 30, 2025

TarLaboratories added 8 commits December 30, 2025 12:25

revert random capes change

69d0c90

docs and stuff

9d29eab

i love javadocs

7a18e5b

formatting

d8f673e

move most logic from mixin to capability

3093483

more tests

245e5d8

even more tests

839f7d8

make filtering test not ignore nbt

66642a7

jurrejelle requested changes Jan 3, 2026

View reviewed changes

		- A block and an item handler (contains `Level`, `BlockPos`, `IItemHandler` and an `int` slot, that may be `-1`)
		- An entity, usually a player (contains `Entity` and an `int` slot, that may be `-1`)

Spoilage #3874

Are you sure you want to change the base?

Spoilage #3874

Uh oh!

Conversation

TarLaboratories commented Sep 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Implementation Details

Outcome

Uh oh!

jurrejelle left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jurrejelle commented Sep 7, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jurrejelle left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

TarLaboratories commented Sep 7, 2025 •

edited

Loading