fix: drop manifest screenOrientation portrait (#1171)#1227
Open
pradhyumna186 wants to merge 1 commit intoGreenstand:masterfrom
Open
fix: drop manifest screenOrientation portrait (#1171)#1227pradhyumna186 wants to merge 1 commit intoGreenstand:masterfrom
pradhyumna186 wants to merge 1 commit intoGreenstand:masterfrom
Conversation
…nd ImageCaptureActivity to satisfy Google Play large-screen resizability/orientation requirements (Android 16+).
Contributor
|
As mentioned in the related issue, this will not be merged until we have proper support for landscape. |
Contributor
Author
|
I will work on it |
|
Hi, I'm Shivani from the Greenstand design team. I'd like to work on the landscape UI designs for this PR. Happy to be assigned! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes manifest
android:screenOrientation="portrait"fromTreeTrackerActivityandImageCaptureActivityso the app no longer declares orientation locks that conflict with Google Play guidance for large screens and Android 16+ behavior. Previous values are preserved as XML comments with context (seeAndroidManifest.xml).Fixes #1171
Checklist
./codeAnalysis(formatting + lint).Verification (please review)
Short screen recording attached showing the app rotating between portrait and landscape on a Resizable emulator to see current behavior after removing the manifest lock.
Landscape / large-screen notes (future work, not blocking this PR):
Screen_recording_20260403_102559.webm
Screen_recording_20260403_102535.webm
Screen_recording_20260403_102627.webm
Notes