feat: Added feature to base64 decode the value in GSM#595
feat: Added feature to base64 decode the value in GSM#595aminsaedi wants to merge 4 commits intoGoogleCloudPlatform:mainfrom
Conversation
aminsaedi
requested review from
NaMNDV,
abheda-crest,
amitmodak,
arpangoswami,
dargudear-google and
jainsuyogj
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Thanks for the PR, I'll review it by next EOW. |
aminsaedi
had a problem deploying
to
e2e-test
GitHub Actions
Failure
|
@dargudear-google Could you please review again? |
|
Please also update the e2e test test/e2e/. |
|
@dargudear-google I think the E2E tests are failing due to authentication issues with forked PRs, not due to my code changes. Could you please help me how to resolve it? |
Yes it is known limitation but we can run it after merge and resolve any issues afterwords. |
|
@dargudear-google Could you please check this PR? |
key was expired which I fixed it now |
|
So could you please run the CI jobs again? Thanks. |
|
I can not see any changes in test/e2e/ ? |
2 participants
This PR adds a new
decodeBase64field to the Secret configuration that allows automatic base64 decoding of secret values retrieved from GSM and Parameter Manager before mounting them to pods.Motivation
We use a third-party service that stores secrets in GSM in base64-encoded format. Currently, when these secrets are mounted to pods, they remain base64-encoded, requiring additional decoding steps within the application. This feature removes that extra step by decoding the values directly in the CSI driver.