Add params to row-filter and modify to be used multiple at the same time

[bogo96]

• add params
• allow multi-use
• modify config as changes

Related Issue

#171

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

[thinhha]

/gcbrun

[thinhha]

Hi @bogo96 thanks for this amazing first contributions!

I've approved for both Github Actions and Cloud Run to run on your PR. Looks like Github Actions is failing because of #70 (there is no workaround).

The Cloud Build logs are not directly visible in Github so I need to share them with you here. The tests are currently failing due to:

Failed to parse Rule Binding with error:
Config ID: T3_DQ_1_EMAIL_DUPLICATE must define non-empty value: 'row_filter_ids'.

This is because of #174 (comment). What do you think about (2) allow one-of 'row_filter_id' which is a string or 'row_filter_ids' which is a list instead?

BTW wanted to check if you are able to run make test from where you are creating this PR?

Thanks again!
Thinh

[bogo96]

Hi @bogo96 thanks for this amazing first contributions!

I've approved for both Github Actions and Cloud Run to run on your PR. Looks like Github Actions is failing because of #70 (there is no workaround).

The Cloud Build logs are not directly visible in Github so I need to share them with you here. The tests are currently failing due to:

Failed to parse Rule Binding with error:
Config ID: T3_DQ_1_EMAIL_DUPLICATE must define non-empty value: 'row_filter_ids'.

This is because of #174 (comment). What do you think about (2) allow one-of 'row_filter_id' which is a string or 'row_filter_ids' which is a list instead?

BTW wanted to check if you are able to run make test from where you are creating this PR?

Thanks again! Thinh

Hi, I really appreciated with your review. I wonder how to make test in my local.
I think i have to do something to my gcp project and dataset. Cause once I ran make test, there are some fails about not exist of table which in bigquery-public-data project even though I made contact_details table in my dataset.
Is there any guide about it?

[thinhha]

LGTM - thanks! I will create a separate PR to create a few more test for this PR before merging to main.

[thinhha]

Thanks for this @bogo96 & apologies for the delay.
@AmandeepSinghCS will start looking into adding tests to this change. We may need to recreate the change in a different branch to run the tests, and then figure out how to merge those changes back into this branch to merge.