chore(deps): update golang docker tag to v1.26#196
chore(deps): update golang docker tag to v1.26#196renovate-bot wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
Summary of ChangesHello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request aims to update the Go version to 1.26 by changing the Docker base image. However, this change is incomplete. The go.mod file for this project contains go 1.25.0 and toolchain go1.25.7 directives, which pin the build to use Go toolchain version 1.25.7, regardless of the version present in the Docker image. For the update to be effective, the go.mod file must also be updated to reflect the new Go version.
|
|
||
| # Build stage | ||
| FROM golang:1.25 as builder | ||
| FROM golang:1.26 as builder |
There was a problem hiding this comment.
While the base image is updated to golang:1.26, this change is not sufficient to update the Go version used for the build. The go.mod file in this directory specifies toolchain go1.25.7, which forces the Go toolchain to use that specific version, ignoring the one provided by the Docker image.
To complete the upgrade to Go 1.26, you must also update pre-sync/oci-image-verification/go.mod:
- go 1.25.0
- toolchain go1.25.7
+ go 1.26.0
+ toolchain go1.26.0Without updating go.mod, this Dockerfile change has no effect.
This PR contains the following updates:
1.25→1.26Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.