Skip to content

Issue 31:factor messages options #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ShlomiShitrit merged 3 commits into from
Dec 8, 2024
Merged

Issue 31:factor messages options #43

ShlomiShitrit merged 3 commits into from
Dec 8, 2024

Conversation

@ShlomiShitrit
Copy link
Collaborator

@ShlomiShitrit ShlomiShitrit commented Nov 24, 2024 •
edited
Loading

fix #31

image:I
image

@github-actions
Copy link

github-actions bot commented Nov 24, 2024 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟢 Statements
81.52% (-0.81% 🔻)
 909/1115
🟢 Branches 80.33% 49/61
🔴 Functions 40.48% 17/42
🟢 Lines
81.52% (-0.81% 🔻)
 909/1115
Show files with reduced coverage 🔻
St.❔
 File Statements Branches Functions Lines
🔴
... / resources.ts
55.56% (-9.75% 🔻)
 66.67% 40%
55.56% (-9.75% 🔻)

Test suite run success

33 tests passing in 10 suites.

Report generated by 🧪jest coverage report action from c359f6d

nadavWeisler
nadavWeisler reviewed Nov 25, 2024
View reviewed changes
src/app/general/resources.ts Outdated
id: index,
text: prm?.message ?? `Enter value for parameter ${prm?.name}:`,
text:
(prm?.message ?? `Enter value for parameter ${prm?.name}:`) +
Copy link
Contributor

@nadavWeisler nadavWeisler Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To resources

Copy link
Collaborator Author

@ShlomiShitrit ShlomiShitrit Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@ShlomiShitrit
Copy link
Collaborator Author

ShlomiShitrit commented Dec 4, 2024

@nadavWeisler I moved a lot of strings to constants.ts. Take a look

@ShlomiShitrit ShlomiShitrit changed the title Issue 31:factor messages oprions Issue 31:factor messages options Dec 4, 2024
@ShlomiShitrit ShlomiShitrit merged commit 02da84e into main Dec 8, 2024
3 checks passed
@ShlomiShitrit ShlomiShitrit deleted the ShlomiShitrit/issue31 branch December 8, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nadavWeisler nadavWeisler nadavWeisler approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

add factor options in factor operators messages

3 participants

@ShlomiShitrit @nadavWeisler