Skip to content

AUTOMATION: Clean Detekt Baseline Files #6074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VelikovPetar merged 1 commit into from
Jan 9, 2026
Merged

AUTOMATION: Clean Detekt Baseline Files #6074

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions stream-chat-android-state/detekt-baseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
<?xml version="1.0" ?>
<?xml version='1.0' encoding='UTF-8'?>
<SmellBaseline>
<ManuallySuppressedIssues></ManuallySuppressedIssues>
<ManuallySuppressedIssues/>
<CurrentIssues>
<ID>EmptyFunctionBlock:DeleteChannelListenerState.kt$DeleteChannelListenerState${ }</ID>
<ID>ForbiddenComment:ChatEventUtils.kt$// TODO: Backend should send us the last read message id</ID>
<ID>ForbiddenComment:ChatEventUtils.kt$// TODO: remove this once the backend is fixed and is sending us the number of unread messages</ID>
<ID>ForbiddenComment:EventBatchUpdate.kt$EventBatchUpdate$// TODO: this overwrites members which in the case when you have &gt; 100 members isn't the right behaviour</ID>
<ID>ForbiddenComment:EventBatchUpdate.kt$EventBatchUpdate$// TODO: this overwrites members which in the case when you have > 100 members isn't the right behaviour</ID>
<ID>LargeClass:CustomObjectFilteringTest.kt$CustomObjectFilteringTest$Companion</ID>
<ID>LongMethod:ChannelLogic.kt$ChannelLogic$internal fun handleEvent(event: ChatEvent)</ID>
<ID>LongMethod:ChatClientExtensionTests.kt$ChatClientExtensionTests$@BeforeEach fun setUp()</ID>
<ID>LongMethod:CustomObjectFilteringTest.kt$CustomObjectFilteringTest.Companion$@JvmStatic fun distinctFilterArguments()</ID>
<ID>LongMethod:CustomObjectFilteringTest.kt$CustomObjectFilteringTest.Companion$@JvmStatic fun equalsFilterArguments()</ID>
Expand All @@ -23,13 +22,12 @@
<ID>MagicNumber:QueryChannelPaginationRequest.kt$QueryChannelPaginationRequest$30</ID>
<ID>MagicNumber:StatePluginConfig.kt$StatePluginConfig$12</ID>
<ID>MagicNumber:SyncManager.kt$SyncManager$30</ID>
<ID>MaxLineLength:ChannelLogic.kt$ChannelLogic$*</ID>
<ID>MaxLineLength:ChannelsStateData.kt$ChannelsStateData.OfflineNoResults$/** If we are offline and don't have channels stored in offline storage, typically displayed as an error condition. */</ID>
<ID>MaxLineLength:ChatClient.kt$*</ID>
<ID>MaxLineLength:CustomObjectFiltering.kt$compare(t.getMemberPropertyOrExtra(fieldName, value::class) as? Comparable&lt;Any&gt;, value as? Comparable&lt;Any&gt;) { it &lt; 0 }</ID>
<ID>MaxLineLength:CustomObjectFiltering.kt$compare(t.getMemberPropertyOrExtra(fieldName, value::class) as? Comparable&lt;Any&gt;, value as? Comparable&lt;Any&gt;) { it &lt;= 0 }</ID>
<ID>MaxLineLength:CustomObjectFiltering.kt$compare(t.getMemberPropertyOrExtra(fieldName, value::class) as? Comparable&lt;Any&gt;, value as? Comparable&lt;Any&gt;) { it &gt; 0 }</ID>
<ID>MaxLineLength:CustomObjectFiltering.kt$compare(t.getMemberPropertyOrExtra(fieldName, value::class) as? Comparable&lt;Any&gt;, value as? Comparable&lt;Any&gt;) { it &gt;= 0 }</ID>
<ID>MaxLineLength:CustomObjectFiltering.kt$compare(t.getMemberPropertyOrExtra(fieldName, value::class) as? Comparable&lt;Any>, value as? Comparable&lt;Any>) { it &lt; 0 }</ID>
<ID>MaxLineLength:CustomObjectFiltering.kt$compare(t.getMemberPropertyOrExtra(fieldName, value::class) as? Comparable&lt;Any>, value as? Comparable&lt;Any>) { it &lt;= 0 }</ID>
<ID>MaxLineLength:CustomObjectFiltering.kt$compare(t.getMemberPropertyOrExtra(fieldName, value::class) as? Comparable&lt;Any>, value as? Comparable&lt;Any>) { it > 0 }</ID>
<ID>MaxLineLength:CustomObjectFiltering.kt$compare(t.getMemberPropertyOrExtra(fieldName, value::class) as? Comparable&lt;Any>, value as? Comparable&lt;Any>) { it >= 0 }</ID>
<ID>MaxLineLength:CustomObjectFiltering.kt$getMemberPropertyOrExtra(MEMBERS_FIELD_NAME, List::class)?.mapNotNull { (it as? Member)?.getUserId() } ?: emptyList()</ID>
<ID>MaxLineLength:CustomObjectFilteringTest.kt$CustomObjectFilteringTest.Companion$randomChannel(members = (List(positiveRandomInt(10)) { randomMember() } + randomMember(randomUser(id = memberId))).shuffled())</ID>
<ID>MaxLineLength:DeleteReactionErrorHandlerImpl.kt$DeleteReactionErrorHandlerImpl$*</ID>
Expand All @@ -40,7 +38,7 @@
<ID>MaxLineLength:SocketEventCollector.kt$SocketEventCollector$*</ID>
<ID>MaxLineLength:StatePlugin.kt$StatePlugin$*</ID>
<ID>MaxLineLength:SyncManager.kt$SyncManager$*</ID>
<ID>NestedBlockDepth:CustomObjectFiltering.kt$@Suppress("UNCHECKED_CAST") internal fun &lt;T : CustomObject&gt; FilterObject.filter(t: T): Boolean</ID>
<ID>NestedBlockDepth:CustomObjectFiltering.kt$@Suppress("UNCHECKED_CAST") internal fun &lt;T : CustomObject> FilterObject.filter(t: T): Boolean</ID>
<ID>SwallowedException:CustomObjectFiltering.kt$e: ClassCastException</ID>
<ID>TooGenericExceptionCaught:ChatClient.kt$exception: Exception</ID>
<ID>TooGenericExceptionCaught:EventHandlerSequential.kt$EventHandlerSequential$e: Throwable</ID>
Expand Down
Loading