eng(build): upgrade analyzer, build and source_gen dependencies by JaseElder · Pull Request #650 · GetDutchie/brick

JaseElder · 2025-10-23T00:48:19Z

Hi,

This PR should address the issues with out of date dependencies for analyzer, source_gen and build.
There were a few breaking changes since the last compatible analyzer version, so there were quite a few API deprecations and deletions.

Almost all tests are passing, but for the tests that deal with nullability type mismatches in Constructors, e.g.
in packages/brick_offline_first_build/test/offline_first_generator_test.dart the test CustomOfflineFirstSerdes
These are failing - I couldn't track down where the type needed to be modified.
But that affects ~3 tests, and I'd imagine you'll be able to track it down instantly.

bookshiyi · 2025-10-23T07:54:45Z

great!

tshedor · 2025-10-24T03:21:06Z

example_supabase/lib/brick/adapters/customer_adapter.g.dart

+  required SupabaseProvider provider,
+  OfflineFirstWithSupabaseRepository? repository,
+}) async {
+  return Customer();


data should still populate the Customer instance fields

tshedor · 2025-10-24T03:21:17Z

example_supabase/lib/brick/adapters/customer_adapter.g.dart

+  required SqliteProvider provider,
+  OfflineFirstWithSupabaseRepository? repository,
+}) async {
+  return Customer()..primaryKey = data['_brick_id'] as int;


tshedor · 2025-10-24T03:21:59Z

example_supabase/lib/brick/adapters/pizza_adapter.g.dart

+  required SupabaseProvider provider,
+  OfflineFirstWithSupabaseRepository? repository,
+}) async {
+  return Pizza();


@JaseElder did you generate these?

@tshedor I didn't knowingly regenerate them. I tried to stay away from the example folders. They may have been generated during rework - I'll try to explicitly gen.

tshedor · 2025-10-24T03:22:44Z

example_supabase/lib/brick/adapters/pizza_adapter.g.dart

+  required SqliteProvider provider,
+  OfflineFirstWithSupabaseRepository? repository,
+}) async {
+  return Pizza()..primaryKey = data['_brick_id'] as int;


tshedor · 2025-10-24T03:26:03Z

packages/brick_build/lib/src/utils/fields_for_class.dart

+    if (!checkerA.isExactly(b.enclosingElement)) {
      // in this case, you want to prioritize the enclosingElement that is more "super".
-      if (checkerA.isAssignableFrom(b.enclosingElement3)) {
+      if (checkerA.isAssignableFrom(b.enclosingElement)) {


Non-actionable feedback here. The analyzer team is so inconsistent. When I first wrote this code there were no numbers. Now they're going back to numbers. But it's all the same property and same value. I wish they would stop publishing these breaking changes. Thank you again for taking the effort to update these.

Also it's really hard to find documentation on migration and deprecation for analyzer. And quite a few of the methods/properties were deprecated in intermediate analyzer versions, and then completely removed in the latest, so working out what the replacement path is was frustrating.

tshedor · 2025-10-24T03:28:29Z

packages/brick_build/pubspec.yaml


 dependencies:
-  analyzer: ">=6.11.0 <8.0.0"
+  analyzer: ">=6.11.0 <9.0.0"


Is this minimum version still valid?

Suggested change

analyzer: ">=6.11.0 <9.0.0"

analyzer: ">=8.0.0 <9.0.0"

Upgraded minimum

tshedor · 2025-10-24T03:29:15Z

packages/brick_build/pubspec.yaml

+  analyzer: ">=6.11.0 <9.0.0"
  brick_core: ">=2.0.0 <3.0.0"
-  build: ">=2.4.2 <2.5.0"
+  build: ">=2.4.2 <5.0.0"


Similarly. It's OK to keep this restricted

Suggested change

build: ">=2.4.2 <5.0.0"

build: ">=4.0.0 <5.0.0"

Upgraded minimum

tshedor · 2025-10-24T03:29:42Z

packages/brick_build_test/pubspec.yaml

 repository: https://github.com/GetDutchie/brick

-version: 3.0.0
+version: 3.0.1


Suggested change

version: 3.0.1

version: 3.1.0

Upgraded minimum

tshedor · 2025-10-24T03:31:07Z

packages/brick_json_generators/pubspec.yaml


 dependencies:
-  analyzer: ">=6.11.0 <8.0.0"
+  analyzer: ">=6.11.0 <9.0.0"


I won't go through every pubspec, but they can all be updated to one major version less than the highest band

Upgraded minimums

tshedor · 2025-10-24T03:36:15Z

packages/brick_sqlite_generators/lib/src/sqlite_schema/migration_generator.dart

  }
+
+  /// Extract filename from library identifier path
+  static String _extractFilename(String libraryPath) {


This feels...off. But I also know that source gen doesn't really want you to know the path of the file you're generating. This is the best solution given the new properties available?

Yeah this was messy - I've made it more aligned with the new properties now, I think.

… dependencies - reverted generated file changes in example_supabase - simplified allMigrationsByFilePath() file path fetching

# Conflicts: # packages/brick_json_generators/pubspec.yaml # packages/brick_offline_first_build/pubspec.yaml # packages/brick_offline_first_with_supabase_build/pubspec.yaml # packages/brick_rest_generators/pubspec.yaml # packages/brick_sqlite_generators/pubspec.yaml # packages/brick_supabase_generators/pubspec.yaml

… dependencies - reverted generated file changes in example_supabase - simplified allMigrationsByFilePath() file path fetching

JaseElder · 2025-10-30T15:20:47Z

@tshedor

Those are the tests I was talking about above.
They are all related to a mismatch where the constructor has a nullable field, but the corresponding instance variable isn't nullable, as in the test example:

@SupabaseSerializable()
class SupabaseConstructorMemberFieldMismatch extends SupabaseModel {
  final String nullableConstructor;
  final String nonNullableConstructor;

  final List<Assoc> someField;

  SupabaseConstructorMemberFieldMismatch({
    String? nullableConstructor,
    required this.nonNullableConstructor,
    List<Assoc>? someField,
  })  : nullableConstructor = nullableConstructor ?? 'default',
        someField = someField ?? <Assoc>[];
}

In this case, nullableConstructor is the culprit.

If you could point me in the direction of where to look to modify the generator to make the test past, I could amend the code. Otherwise, it might be faster for you to have a look.

tshedor · 2025-11-01T20:35:18Z

packages/brick_build/lib/src/serdes_generator.dart

    final defaultConstructor = _firstWhereOrNull<ConstructorElement>(
      element.constructors,
-      (e) => !e.isFactory && e.name.isEmpty,
+      (e) => !e.isFactory && ((e.name?.isEmpty ?? true) || e.name == 'new'),


@JaseElder this was the missing logic that was breaking tests. The default (unnamed) constructor is no longer unnamed in the analyzer, it's now 'new'

@tshedor Nice one!
Thanks for the help and the repo update

JaseElder added 13 commits October 6, 2025 14:33

- upgraded dependencies

30f7696

- upgrade dependencies

a088066

- upgrade dependencies

a914e08

- upgrade dependencies

baf4f94

- upgrade dependencies

6855479

- upgrade dependencies

ed95795

- upgrade dependencies

bd3fe30

Merge branch 'GetDutchie:main' into main

b8e6306

- upgraded analyzer to 8.4.0, source_gen to 4.0.2 and build to 4.0.2

22e4cf2

Merge branch 'main' of https://github.com/JaseElder/brick into local

69bcf9a

- upgraded analyzer to 8.4.0, source_gen to 4.0.2 and build to 4.0.2

f46ee7c

Merge branch 'main' of https://github.com/JaseElder/brick into local

0b97b36

Merge remote-tracking branch 'origin/main' into main

5f94b09

JaseElder requested a review from tshedor as a code owner October 23, 2025 00:48

JaseElder mentioned this pull request Oct 23, 2025

Support build 4.x for brick_offline_first_with_supabase_build #638

Closed

tshedor reviewed Oct 24, 2025

View reviewed changes

JaseElder added 4 commits October 24, 2025 16:24

- upgraded minimum versions in analyzer, build and source_gen package…

70f0f57

… dependencies - reverted generated file changes in example_supabase - simplified allMigrationsByFilePath() file path fetching

- upgraded minimum versions in analyzer, build and source_gen package…

bafe76e

… dependencies - reverted generated file changes in example_supabase - simplified allMigrationsByFilePath() file path fetching

Merge remote-tracking branch 'origin/main' into main

dd35061

tshedor added 4 commits November 1, 2025 12:42

test edit

2b332a6

resolve analyzer and pubspec dependencies

9545058

resolve default constructor errors

2543b1d

use unawaited

14f5908

tshedor reviewed Nov 1, 2025

View reviewed changes

add changelog notes for all packages

b32261e

tshedor changed the title ~~Upgraded analyzer, build and source_gen dependencies~~ eng(build): upgrade analyzer, build and source_gen dependencies Nov 1, 2025

tshedor previously approved these changes Nov 1, 2025

View reviewed changes

revert gql update

c47b693

tshedor dismissed their stale review via c47b693 November 1, 2025 21:05

tshedor merged commit 4395194 into GetDutchie:main Nov 1, 2025
26 checks passed

Conversation

JaseElder commented Oct 23, 2025

Uh oh!

bookshiyi commented Oct 23, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JaseElder commented Oct 30, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants