fix(sqlite): enumAsString generates varchar column instead of integer #597#604
fix(sqlite): enumAsString generates varchar column instead of integer #597#604
Conversation
mateominato
left a comment
mateominato
left a comment
There was a problem hiding this comment.
approving cause no context but 95% of this PR seems to be regenerated test output thats only reformatted, and a bunch of print statements that i assume were meant to be removed
| if (generated.trim() != output.trim()) { | ||
| // ignore: avoid_print | ||
| print(generated); | ||
| } |
There was a problem hiding this comment.
was this debugging code you meant to remove?
There was a problem hiding this comment.
It's intentional for tests. Helps to update the test cases faster
packages/brick_graphql_generators/test/graphql_model_serdes_generator_test.dart
Show resolved
Hide resolved
| return SchemaColumn( | ||
| column.name!, | ||
| Column.integer, | ||
| column.enumAsString ? Column.varchar : Column.integer, |
There was a problem hiding this comment.
is this the only real change in this PR? the rest looks like line length regeneration and a bunch of debug print statements
There was a problem hiding this comment.
Well build released a "minor" version with breaking changes. This affected build_test as it was reaching out for a class that no longer existed. So I had to run dart pub upgrade and the new tests had a bunch of formatting changes that were included. It's annoying, but I figured it'd be better to do this in one PR than be surprised later
|
Thank @mateominato and @tshedor for getting this fixed. I ran into the issue today. When can we expect to see updates to the brick_sqlite_generators, brick_graphql_generators, etc packages? |
3 participants
No description provided.