Refactor PrometheusController + Tests + Errors, MetricsService and MessageService and their Dependencies to AutomaUtilities #198
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason
PrometheusController,MetricsServiceandMessageServicewill be used in packages and repositories other than Backend package and AutomaInfraCore repository. Moving these structs to AutomaUtilities will allow other repositories and Swift packages to use them as well.Tech Details List
MetricsService,PrometheusController,PrometheusControllerErrorsandPrometheusControllerIntegrationTestsfrom AutomaInfracore to AutomaUtilities.MessageServiceintoMessageServiceandSNSService(message service just for discord messages, sns service for SMS's), and move MessageService along with all of its imported code from AutomaInfracore to AutomaUtilities.AutomaUtilitiespackage after refactor PR has been merged.AutomaUtilitiespackage whereMetricsService,PrometheusController,MessageServiceand their dependencies are usedTasks:
MetricsService,PrometheusController,PrometheusControllerErrorsandPrometheusControllerIntegrationTestsfrom AutomaInfracore to AutomaUtilities.MessageServiceintoMessageServiceandSNSService(message service just for discord messages, sns service for SMS's), and move MessageService along with all of its imported code from AutomaInfracore to AutomaUtilities.AutomaUtilitiespackage after refactor PR has been merged.AutomaUtilitiespackage whereMetricsService,PrometheusController,MessageServiceand their dependencies are usedUn-important tasks:
Links:
AutomaUtilities Refactor Pull Request (already merged)
Testing
Steps:
TESTING-QAOutput:
Testing QA