Skip to content

Send emails for new manuscripts for each subscription #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nuest merged 18 commits into from
Apr 8, 2025
Merged

Send emails for new manuscripts for each subscription #90

nuest merged 18 commits into from
Apr 8, 2025

Conversation

@uxairibrar
Copy link
Collaborator

@uxairibrar uxairibrar commented Feb 13, 2025 •
edited by nuest
Loading

Closes #71

  • Set up subscription-based email sending, fetching users with active subscriptions and sending manuscript updates.
  • Created unsubscribe functionality allowing users to opt-out from specific or all subscriptions via email links.
  • Formatted emails in HTML with bullet-point manuscript lists for better readability.
  • Implemented monthly email scheduling using Django-Q to send emails to subscribed users about new manuscripts.
  • Added an Admin action to manually trigger subscription-based emails from the admin panel.

nuest
nuest reviewed Feb 19, 2025
View reviewed changes
Copy link
Member

@nuest nuest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very much going in the right direction - I suggest to revisit this after we merge the simpler email sending PR #89

@nuest nuest changed the title Send emails for new manuscripts for each subscription 71 Send emails for new manuscripts for each subscription Feb 21, 2025
@nuest nuest mentioned this pull request Mar 12, 2025
Open
nuest
nuest reviewed Mar 19, 2025
View reviewed changes
Copy link
Member

@nuest nuest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure you already wanted input here, but I have a few minor comments.

Happy to merge soon, AFAICT only some tests are missing.

@uxairibrar uxairibrar marked this pull request as draft March 27, 2025 03:56
@uxairibrar uxairibrar requested a review from nuest April 4, 2025 13:34
@uxairibrar uxairibrar marked this pull request as ready for review April 4, 2025 13:46
nuest
nuest requested changes Apr 4, 2025
View reviewed changes
Copy link
Member

@nuest nuest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good, I'm only missing the tests.

@uxairibrar
Copy link
Collaborator Author

uxairibrar commented Apr 4, 2025

I have updated the tests

@nuest
Copy link
Member

nuest commented Apr 4, 2025

@uxairibrar Tests are failing. Please fix the unit tests.

@nuest nuest merged commit 186f501 into main Apr 8, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nuest nuest nuest approved these changes

Assignees

@uxairibrar uxairibrar

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Send emails for new manuscripts for each subscription

3 participants

@uxairibrar @nuest