-
Notifications
You must be signed in to change notification settings - Fork 0
Harvest data from online OJS instances at fixed interval #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nuest
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any code related to Django-Q in this PR.
Could you please add a few illustrating screenshots how the interaction with the admin UI works? Thanks!
So, I wanted to automate this scheduling process, so I put adding scheduler on save in the models file. However, now I have also added a seperate admin action for it. |
|
@uxairibrar Tests are working again and branch is updated from main. |
nuest
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good - please just fix the failing tests: https://github.com/GeoinformationSystems/optimap/actions/runs/14266473472/job/39989399641?pr=87
nuest
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll go ahead and merge - thanks for the efforts.
I do think though that we will have to improve the tests over time, as not all conditions are tested, for example:
- You check for "greater than zero" many publications, when you should know the exact number and test for that.
- You test only that the DOI starts with "10.", when you know the exact DOI. What if the regex if incorrect towards the end of the DOI?
Closes #47