-
Notifications
You must be signed in to change notification settings - Fork 0
Workflow for Regular Metadata #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nuest
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a little oversight, I think, to remove the temporal field extraction, and a little shift in approaching the solution: it is more important not to fail if geometries are missing, but if they are there, we surely would like them.
Therefore I am not sure how important the harvest_regular... as a seperate function really is.
Do you think you can just put it all in one function that creates sensible output if there are no geometries?
|
Everything is resolved from my side, please take a look at the failing unit test (it looks rather simple to fix?) and I'll merge right away if that is resolved. |
nuest
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the deduplication to not query all identifiers from the database every time we insert a new record, but instead rely on the database index to be fast.
Closes #23