Skip to content

Conversation

@uxairibrar
Copy link
Collaborator

@uxairibrar uxairibrar commented Apr 13, 2025

Closes #23

  • Updated the function to extract only regular textual metadata (skipping geospatial and temporal fields) for manual entry.
  • Linked new Publication records to a HarvestingEvent with user and timestamp details.
  • Compiled metadata counts and sent an email notification to the initiating user with job details (including collection name and journal URL).
  • Added testcase.

Copy link
Member

@nuest nuest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little oversight, I think, to remove the temporal field extraction, and a little shift in approaching the solution: it is more important not to fail if geometries are missing, but if they are there, we surely would like them.

Therefore I am not sure how important the harvest_regular... as a seperate function really is.

Do you think you can just put it all in one function that creates sensible output if there are no geometries?

@nuest
Copy link
Member

nuest commented Apr 16, 2025

Everything is resolved from my side, please take a look at the failing unit test (it looks rather simple to fix?) and I'll merge right away if that is resolved.

Copy link
Member

@nuest nuest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the deduplication to not query all identifiers from the database every time we insert a new record, but instead rely on the database index to be fast.

@nuest nuest changed the title Workflow for Regular Metdata Workflow for Regular Metadata Apr 23, 2025
@nuest nuest merged commit 2bc15e7 into main Apr 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide workflow to harvest only regular metadata from OJS and then add geospatial metadata manually

3 participants