Skip to content

FRDQ-107 - Data converter #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
TomaszKorenberg wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

FRDQ-107 - Data converter #138

TomaszKorenberg wants to merge 1 commit into from

Conversation

@TomaszKorenberg
Copy link
Contributor

@TomaszKorenberg TomaszKorenberg commented Jun 2, 2021

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2021

Related Issue: #107 Create an algorithm to convert users from DB into format for structure

@hayuna hayuna marked this pull request as draft June 3, 2021 09:31
@hayuna hayuna linked an issue Jun 3, 2021 that may be closed by this pull request
Create an algorithm to convert users from DB into format for structure #107
Open
@hayuna
Copy link
Member

hayuna commented Jun 3, 2021 •
edited
Loading

  1. This algorithm cannot connect members.
  2. This algorithm create different structure of socials than expected. (you can use Array.prototype.reduce to change structure of object)

hayuna
hayuna requested changes Jun 3, 2021
View reviewed changes
Copy link
Member

@hayuna hayuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rejected

@hayuna
Copy link
Member

hayuna commented Jun 3, 2021

Take a look at this solution

#142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hayuna hayuna hayuna requested changes

@hendrysiak hendrysiak Awaiting requested review from hendrysiak

@Krysik Krysik Awaiting requested review from Krysik

@MaciejSpalek MaciejSpalek Awaiting requested review from MaciejSpalek

@MarW5 MarW5 Awaiting requested review from MarW5

@PiotrGrobelak PiotrGrobelak Awaiting requested review from PiotrGrobelak

@Tubka Tubka Awaiting requested review from Tubka

@zeglarz zeglarz Awaiting requested review from zeglarz

Requested changes must be addressed to merge this pull request.

Assignees

@TomaszKorenberg TomaszKorenberg

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create an algorithm to convert users from DB into format for structure

3 participants

@TomaszKorenberg @hayuna