Skip to content

Conversation

@kuukitenshi
Copy link
Contributor

Description

Added relation creation and removal detection to observers to allow .onRelate<ChildOf> and .onUnrelate<ChildOf>.

Checklist

  • Self-review changes.
  • Ensure test coverage.
  • Add entry to the changelog's unreleased section.

@kuukitenshi kuukitenshi requested a review from RiscadoA as a code owner April 20, 2025 19:42
@kuukitenshi kuukitenshi linked an issue Apr 20, 2025 that may be closed by this pull request
@kuukitenshi kuukitenshi self-assigned this Apr 20, 2025
@github-actions github-actions bot added A-Core B-ECS P-Urgent This issue is a big priority, and it would be good to close it ASAP labels Apr 20, 2025
@kuukitenshi kuukitenshi added this to the 0.7 milestone Apr 20, 2025
@github-actions
Copy link
Contributor

PR Preview Action v1.6.1

🚀 View preview at
https://GameDevTecnico.github.io/cubos/preview/pr-1494/

Built to branch gh-pages at 2025-04-20 19:44 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Apr 20, 2025

Codecov Report

Attention: Patch coverage is 60.82474% with 38 lines in your changes missing coverage. Please review.

Project coverage is 52.72%. Comparing base (78cda3b) to head (93da688).

Files with missing lines Patch % Lines
core/src/ecs/cubos.cpp 0.00% 34 Missing ⚠️
core/src/ecs/world.cpp 60.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1494      +/-   ##
==========================================
- Coverage   52.73%   52.72%   -0.02%     
==========================================
  Files         479      479              
  Lines       26261    26358      +97     
  Branches     2440     2455      +15     
==========================================
+ Hits        13848    13896      +48     
- Misses      12413    12462      +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kuukitenshi kuukitenshi modified the milestones: 0.7, 0.8 Apr 28, 2025
Copy link
Member

@RiscadoA RiscadoA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These observers must not rely on column ids, similarly to what we discussed regarding the entity destruction PR. This is because relations are stored in a different manner from components. We can discuss this later, ping me on discord when you pick this up

@RiscadoA RiscadoA modified the milestones: 0.8, 0.9 Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Core B-ECS P-Urgent This issue is a big priority, and it would be good to close it ASAP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add relation creation and removal detection to observers

3 participants