Skip to content

1418 destroy child entities when parent entities are destroyed #1465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
kuukitenshi wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

1418 destroy child entities when parent entities are destroyed #1465

kuukitenshi wants to merge 1 commit into from

Conversation

@kuukitenshi
Copy link
Contributor

@kuukitenshi kuukitenshi commented Mar 4, 2025

Description

Destroy child entities when parent entities are destroyed

Checklist

  • Self-review changes.
  • Ensure test coverage.
  • Add entry to the changelog's unreleased section.

@kuukitenshi kuukitenshi requested review from a team and RiscadoA as code owners March 4, 2025 00:00
@kuukitenshi kuukitenshi requested review from Dageus and removed request for a team March 4, 2025 00:00
@kuukitenshi kuukitenshi linked an issue Mar 4, 2025 that may be closed by this pull request
Destroy child entities when parent entities are destroyed #1418
Open
@github-actions github-actions bot added A-Engine B-Transform D-Trivial Can be done in 30 minutes P-Urgent This issue is a big priority, and it would be good to close it ASAP labels Mar 4, 2025
@kuukitenshi kuukitenshi self-assigned this Mar 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2025 •
edited
Loading

PR Preview Action v1.6.1

🚀 View preview at
https://GameDevTecnico.github.io/cubos/preview/pr-1465/

Built to branch gh-pages at 2025-04-20 00:41 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@kuukitenshi kuukitenshi force-pushed the 1418-destroy-child-entities-when-parent-entities-are-destroyed branch 2 times, most recently from 625f9c6 to c2d3fad Compare March 4, 2025 00:22
@kuukitenshi kuukitenshi requested a review from mkuritsu March 4, 2025 00:35
@kuukitenshi kuukitenshi marked this pull request as draft March 4, 2025 02:08
@RiscadoA RiscadoA removed request for Dageus and mkuritsu March 18, 2025 17:04
@RiscadoA
Copy link
Member

RiscadoA commented Apr 5, 2025

What's the status on this @kuukitenshi? Would be cool to have it!

@kuukitenshi kuukitenshi force-pushed the 1418-destroy-child-entities-when-parent-entities-are-destroyed branch from c2d3fad to a47aabd Compare April 18, 2025 23:16
@kuukitenshi
Copy link
Contributor Author

kuukitenshi commented Apr 18, 2025 •
edited
Loading

What's the status on this @kuukitenshi? Would be cool to have it!

I'm sorry didn't see :( Working on that, we will have it 🫡

@kuukitenshi kuukitenshi force-pushed the 1418-destroy-child-entities-when-parent-entities-are-destroyed branch 2 times, most recently from 3a74125 to 817db67 Compare April 20, 2025 00:28
@kuukitenshi kuukitenshi force-pushed the 1418-destroy-child-entities-when-parent-entities-are-destroyed branch from 817db67 to cbef56e Compare April 20, 2025 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RiscadoA RiscadoA Awaiting requested review from RiscadoA RiscadoA is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@kuukitenshi kuukitenshi

Labels

A-Engine B-Transform D-Trivial Can be done in 30 minutes P-Urgent This issue is a big priority, and it would be good to close it ASAP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Destroy child entities when parent entities are destroyed

3 participants

@kuukitenshi @RiscadoA