AOE Tool harvest config + small AOE Break logic change#257
Open
LazyFleshWasTaken wants to merge 4 commits intomasterfrom
Open
AOE Tool harvest config + small AOE Break logic change#257LazyFleshWasTaken wants to merge 4 commits intomasterfrom
LazyFleshWasTaken wants to merge 4 commits intomasterfrom
Conversation
LazyFleshWasTaken
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a config for hte max allowed relative hardness (mining speed) difference.
Default 10, nothing changes unless config is modified.
Further, give some allowance to the AOE break by allowing the mine even if the relative hardness is exceeded, but the mining speed allows the tool to mine the block in 1-2 ticks anyway.
i.e. a cobalt hammer won't break the obsidian when mining sandstone, but if the hammer has 750+ mining speed, it will.
Config modification works on dev env:
max relative = 1000
max relative = 10
very high mining speed tool:
cobalt hammer:
addresses GTNewHorizons/GT-New-Horizons-Modpack#9987 if the max relative is increased, tho the issues itself is fixed with ore refactor.