Fix tool forge voiding items bug/desync#244
Conversation
There was a problem hiding this comment.
Instead of mixing into Container, why not just override slotClick in ToolStationContainer.java? Use super to forward the call to Container's slotClick, then ask the tool station to recheck the recipe.
Alright, just pushed the refactor, for some reason this freezes despite master not freezing despite it being a new world with no tool forges. Can't find anything noteworthy in logs too, and setting breakpoints on the code I changed brings up nothing... |
src/main/java/tconstruct/tools/inventory/ToolStationContainer.java
Outdated
Show resolved
Hide resolved
…java Co-authored-by: Nikolay S. <nicksitnikov@gmail.com>
|
Will test after #249 gets merged and the renaming feature of the Tool Station is functional again. |
src/main/java/tconstruct/tools/inventory/ToolStationContainer.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Nikolay S. <nicksitnikov@gmail.com>
Just FYI, I tested it just now and it doesn't freeze anymore. |
I meant "test this PR". I can't prove that your PR fixes the issue, because right now you can't rename items in the Tool Station at all. |
Yeah I know, I was just informing you that the freezing issue doesn't happen anymore. |
This PR fixes a bug where trying to rename items while adding items in multiple steps would cause the amount of output to be desync and void items when clicked.
Fixes GTNewHorizons/GT-New-Horizons-Modpack#22841.