Skip to content

Fix tool forge voiding items bug/desync#244

Merged
Nikolay-Sitnikov merged 10 commits intomasterfrom
rename-void-fix
Feb 4, 2026
Merged

Fix tool forge voiding items bug/desync#244
Nikolay-Sitnikov merged 10 commits intomasterfrom
rename-void-fix

Conversation

@loenaaaa
Copy link

@loenaaaa loenaaaa commented Jan 9, 2026

This PR fixes a bug where trying to rename items while adding items in multiple steps would cause the amount of output to be desync and void items when clicked.

Fixes GTNewHorizons/GT-New-Horizons-Modpack#22841.

@Dream-Master Dream-Master added the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Jan 9, 2026
@Nikolay-Sitnikov Nikolay-Sitnikov self-assigned this Jan 25, 2026
Copy link

@Nikolay-Sitnikov Nikolay-Sitnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of mixing into Container, why not just override slotClick in ToolStationContainer.java? Use super to forward the call to Container's slotClick, then ask the tool station to recheck the recipe.

@loenaaaa
Copy link
Author

loenaaaa commented Jan 31, 2026

Instead of mixing into Container, why not just override slotClick in ToolStationContainer.java? Use super to forward the call to Container's slotClick, then ask the tool station to recheck the recipe.

Alright, just pushed the refactor, for some reason this freezes despite master not freezing despite it being a new world with no tool forges. Can't find anything noteworthy in logs too, and setting breakpoints on the code I changed brings up nothing...

@loenaaaa loenaaaa removed the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Jan 31, 2026
…java

Co-authored-by: Nikolay S. <nicksitnikov@gmail.com>
@Dream-Master Dream-Master added the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Feb 1, 2026
@Nikolay-Sitnikov
Copy link

Will test after #249 gets merged and the renaming feature of the Tool Station is functional again.

loenaaaa and others added 2 commits February 2, 2026 13:10
Co-authored-by: Nikolay S. <nicksitnikov@gmail.com>
@loenaaaa
Copy link
Author

loenaaaa commented Feb 2, 2026

Will test after #249 gets merged and the renaming feature of the Tool Station is functional again.

Just FYI, I tested it just now and it doesn't freeze anymore.

@Nikolay-Sitnikov
Copy link

Will test after #249 gets merged and the renaming feature of the Tool Station is functional again.

Just FYI, I tested it just now and it doesn't freeze anymore.

I meant "test this PR". I can't prove that your PR fixes the issue, because right now you can't rename items in the Tool Station at all.

@loenaaaa
Copy link
Author

loenaaaa commented Feb 2, 2026

Will test after #249 gets merged and the renaming feature of the Tool Station is functional again.

Just FYI, I tested it just now and it doesn't freeze anymore.

I meant "test this PR". I can't prove that your PR fixes the issue, because right now you can't rename items in the Tool Station at all.

Yeah I know, I was just informing you that the freezing issue doesn't happen anymore.

@Nikolay-Sitnikov Nikolay-Sitnikov merged commit 1755470 into master Feb 4, 2026
1 check passed
@Nikolay-Sitnikov Nikolay-Sitnikov deleted the rename-void-fix branch February 4, 2026 02:24
@UltraProdigy UltraProdigy removed the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tool forge can void items when renaming

4 participants

Comments