Effects system for concentrated essence berries#194
Open
Gamingb3ast wants to merge 7 commits intomasterfrom
Open
Effects system for concentrated essence berries#194Gamingb3ast wants to merge 7 commits intomasterfrom
Gamingb3ast wants to merge 7 commits intomasterfrom
Conversation
- Configurable
- OFF BY DEFAULT
- Can apply individual effects based off whether the player ate an individual berry or a stack (held shift (NOT stackSize dependent))
- Added because it feels like berries should be kinda disgusting and hard to eat, maybe even prickly.
Member
|
@Dream-Master has this been tested? |
Member
|
its also on zeta idk if it is tested |
Member
Author
|
I tested my changes but that doesn't really matter does it....:) |
Member
|
I guess we need to switch it on to test it . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created an effects system for eating concentrated essence berries
Configurable
The amplifier is applied gradually based on the duration of the effect.
Can apply individual effects based on whether the player ate an individual berry or a stack (held shift (NOT stackSize dependent))
Added because it feels like berries should be kinda disgusting and hard to eat, maybe even prickly.
My vision was that some modpack creators might like to make a system to extract XP from the berries that isn't just eating them. I thought this would be a better way to allow them to do that rather than outright disabling the consumption of berries.
Not much more to say, it uses potionIDs and attributes for the effects, and it has a damage effect which is impossible to block (some mods add damage immunity, this is just health reduction without the use of magic damage, so it can't be blocked conventionally).