Skip to content

Conversation

@monfresh
Copy link
Contributor

This PR includes the following changes:

  • Replace references to "dashboard" in the Portal URL to "portal"
  • Specify the email domains that can't be used to create accounts in the sandbox
  • Specify that only .gov/.mil users can create Teams in the portal
  • Improve OIDC Getting Started docs to point to existing instructions so we only need to maintain them in one place
  • Improve the certificate rotation steps

@monfresh monfresh requested review from ajfarkas and mmagsa January 20, 2026 15:20
Copy link
Contributor

@ajfarkas ajfarkas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, non-blocking.

There is no registered certificate that matches the signature of the `client_assertion` JWT that is being passed as part of the token. request.
##### What to do:
- Ensure that the public certificate that matches the private key used to sign the JWT is registered in your application's configuration in the [Partner Portal](https://dashboard.int.identitysandbox.gov/){:target="_blank"}.
- Ensure that the public certificate that matches the private key used to sign the JWT is registered in your application's configuration in the [Partner Portal](https://portal.int.identitysandbox.gov/){:target="_blank"}.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 praise: I appreciate you catching these.‏

**For OIDC integrations or SAML integrations sending signed requests:**

1. Add the new certificate to the application portal configuration.
1. Generate your new public/private keypair.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❔ question: is it worth including the link to generating a keypair here?
We're able to link directly to this section, so users may miss the link above.‏

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good idea. For production, we prefer that the certificate be signed by a Certificate Authority, as opposed to being self-signed. I believe that involves different steps than the ones we have. Should we create separate instructions for CA-signed certs?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be great, if you have the bandwidth.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I can do that, but can it be in a separate PR?

@ajfarkas
Copy link
Contributor

ajfarkas commented Jan 20, 2026 via email

@monfresh
Copy link
Contributor Author

It doesn't look like the failing spec is related to this PR. Running npm test locally passes. I reran the job to see if it was a flakey test.

This PR includes the following changes:

- Replace references to "dashboard" in the Portal URL to "portal"
- Specify the email domains that can't be used to create accounts in the sandbox
- Specify that only .gov/.mil users can create Teams in the portal
- Improve OIDC Getting Started docs to point to existing instructions so we only need to maintain them in one place
- Improve the certificate rotation steps
@monfresh monfresh merged commit 2eb3f62 into main Jan 21, 2026
6 checks passed
@monfresh monfresh deleted the update-docs branch January 21, 2026 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants