Skip to content

Conversation

@mmagsa
Copy link
Contributor

@mmagsa mmagsa commented Jul 3, 2025

Part 2 of the accordion refactor started in 555, addressing the remaining accordions.
Also fixes a couple of small bugs (add missing </div> and &->&amp; fix)

Copy link
Contributor

@Sgtpluck Sgtpluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is out of scope of your change but, it's funny that the remote logout accordion has a payload code block that says with indentation added for readability. but almost no indentation. seems like a ux bug to me, wdyt?

@h-m-m
Copy link
Contributor

h-m-m commented Jul 7, 2025

Do you mind including screenshots of this in the PR? Even after-the-change screenshots by themselves are nice. I think I've said this before, but I personally find them very helpful when trying to figure out what someone intended with a past code change when next year browsers or other dependencies may change so the page no longer renders like it used to.

@mmagsa
Copy link
Contributor Author

mmagsa commented Jul 7, 2025

@Sgtpluck good point. Not sure what the thought behind this was. Maybe more indentation would make it harder to read in the fixed-size column? I'll make a ticket to have UX take a look.

@h-m-m nothing changed visually as part of this PR. You still think there should be a screenshot?

@mmagsa
Copy link
Contributor Author

mmagsa commented Jul 7, 2025

@Sgtpluck thinking further about this - remote logout is deprecated, so I think it's ok to leave this as is.

@mmagsa mmagsa merged commit 9fd160c into main Jul 8, 2025
6 checks passed
@mmagsa mmagsa deleted the ma/fixesandaccordions branch July 8, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants