-
Notifications
You must be signed in to change notification settings - Fork 1
update pandera dependency #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #105 +/- ##
=======================================
Coverage 99.31% 99.31%
=======================================
Files 24 24
Lines 1317 1317
Branches 77 77
=======================================
Hits 1308 1308
Misses 8 8
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| - new style pandera import statement | ||
|
|
||
| ### Removed | ||
| - failing performance test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chrisdicaprio it's definitely failing more often recently , but not always... in my experience almost alway on windows... which could indicate a platform issue in GHA or just something special about windows :). Can you pls raise a ticket so we can investigate and decide on best resolution? It may be that the tests are no longer useful, but I'd like to investigate and document the decision.
voj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. love the detailed and helpful description of the PR!
issue 104
It's not possible to import pandera only for type checking as the pandera types are used to define pydantic class fields. Therefore, pandera was moved to the main dependency group.
propcache
During depdency resolution poetry gave the following:
This was resolved with
poetry updatewhich updated to 0.4.1pandera import style
Following warning was also fixed:
failing performance test
Skipping
test_combo_filtering_optionsas it no longer reliably passes. Possibly due to changes in underlying libraries.