Skip to content

Conversation

@chrisdicaprio
Copy link
Collaborator

@chrisdicaprio chrisdicaprio commented Oct 13, 2025

  • closes pandera import #104
  • skip failing performance test
  • change pandera import to new style
  • update propcache in lock file

issue 104

It's not possible to import pandera only for type checking as the pandera types are used to define pydantic class fields. Therefore, pandera was moved to the main dependency group.

propcache

During depdency resolution poetry gave the following:

chrisdc@glacier:~/.../LIB/solvis (fix/104-pandera-dep)$ poetry lock                                       
Creating virtualenv solvis-m31V5c8Z-py3.12 in /data/cache/poetry/virtualenvs
Resolving dependencies... (27.1s)                                                                                                                                                                                  
Warning: The locked version 0.4.0 for propcache is a yanked version. Reason for being yanked: ref leak https://github.com/aio-libs/propcache/issues/159

chrisdc@glacier:~/.../LIB/solvis (fix/104-pandera-dep)$ poetry show propcache
 name         : propcache                                                                                
 version      : 0.4.0                      
 description  : Accelerated property cache 

required by
 - aiohttp requires >=0.2.0
 - yarl requires >=0.2.1

This was resolved with poetry update which updated to 0.4.1

pandera import style

Following warning was also fixed:

/opt/openquake/lib/python3.11/site-packages/pandera/_pandas_deprecated.py:160: FutureWarning: Importing pandas-specific classes and functions from the
top-level pandera module will be **removed in a future version of pandera**.
If you're using pandera to validate pandas objects, we highly recommend updating
your import:

# old import
import pandera as pa

# new import
import pandera.pandas as pa

failing performance test

Skipping test_combo_filtering_options as it no longer reliably passes. Possibly due to changes in underlying libraries.

@chrisdicaprio chrisdicaprio marked this pull request as ready for review October 13, 2025 18:15
@codecov
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.31%. Comparing base (f4f62b8) to head (35c2226).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #105   +/-   ##
=======================================
  Coverage   99.31%   99.31%           
=======================================
  Files          24       24           
  Lines        1317     1317           
  Branches       77       77           
=======================================
  Hits         1308     1308           
  Misses          8        8           
  Partials        1        1           
Flag Coverage Δ
unittests 99.31% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chrisdicaprio chrisdicaprio requested review from chrisbc and voj October 13, 2025 19:14
- new style pandera import statement

### Removed
- failing performance test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrisdicaprio it's definitely failing more often recently , but not always... in my experience almost alway on windows... which could indicate a platform issue in GHA or just something special about windows :). Can you pls raise a ticket so we can investigate and decide on best resolution? It may be that the tests are no longer useful, but I'd like to investigate and document the decision.

Copy link
Collaborator

@voj voj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. love the detailed and helpful description of the PR!

@chrisdicaprio chrisdicaprio merged commit b73f3eb into main Oct 13, 2025
10 checks passed
@chrisdicaprio chrisdicaprio deleted the fix/104-pandera-dep branch October 13, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pandera import

4 participants