Skip to content

feat: refactor #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dk-a-dev merged 3 commits into from
Aug 10, 2025
Merged

feat: refactor #29

dk-a-dev merged 3 commits into from
Aug 10, 2025

Conversation

@RupaakSrinivas
Copy link
Member

@RupaakSrinivas RupaakSrinivas commented Aug 8, 2025 •
edited
Loading

feat: refactor

  • froze lock file versions
  • added pages, implemented guard routes
  • added page transition animations with framer-motion
  • refactored store to user persist(zustand) middleware instead of localstorage
  • timetable store is removed from authStore, both old and new timetable is handled in TimeTableStore using draft flag
  • moved firebase initializeApp to a seperate file to prevent reSubscribes
  • replaced window.alerts with toasts(react-hot-toast)
  • added some memoization to ParseAndReturn function
  • remove yarn.lock ( use only package.lock)

@vercel
Copy link

vercel bot commented Aug 8, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vitty ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 10, 2025 1:40pm

@RupaakSrinivas RupaakSrinivas marked this pull request as draft August 8, 2025 14:57
@dk-a-dev dk-a-dev marked this pull request as ready for review August 8, 2025 15:06
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 8, 2025 •
edited
Loading

Deploying vitty with  Cloudflare Pages  Cloudflare Pages

Latest commit: d8e2aaa
Status: ✅  Deploy successful!
Preview URL: https://91d44d36.vitty.pages.dev
Branch Preview URL: https://refactor.vitty.pages.dev

View logs

@RupaakSrinivas RupaakSrinivas marked this pull request as draft August 8, 2025 17:18
dk-a-dev
dk-a-dev reviewed Aug 8, 2025
View reviewed changes
Copy link
Contributor

@dk-a-dev dk-a-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a campus in profile view and email template

@RupaakSrinivas RupaakSrinivas marked this pull request as ready for review August 10, 2025 13:31
dk-a-dev
dk-a-dev approved these changes Aug 10, 2025
View reviewed changes
Copy link
Contributor

@dk-a-dev dk-a-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dk-a-dev dk-a-dev merged commit 7057a0c into dev-fe Aug 10, 2025
5 checks passed
@dk-a-dev dk-a-dev deleted the refactor branch August 10, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dk-a-dev dk-a-dev dk-a-dev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RupaakSrinivas @dk-a-dev