Skip to content

fix: course title not set when creating a reminder + unique key for timetable #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dk-a-dev merged 2 commits into from
Aug 13, 2025
Merged

fix: course title not set when creating a reminder + unique key for timetable #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9115cdd
fix: course title not set when creating a reminder
JothishKamal Aug 11, 2025
8ea111d
fix: optimize key generation for period items using uuid
JothishKamal Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/src/main/java/com/dscvit/vitty/model/PeriodDetails.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@ package com.dscvit.vitty.model

import com.google.firebase.Timestamp
import java.util.Date
import java.util.UUID

data class PeriodDetails(
// var courseType: String = "",
val id: String = UUID.randomUUID().toString(),
var courseCode: String = "",
var courseName: String = "",
var startTime: Timestamp = Timestamp(Date()),
Expand Down
3 changes: 3 additions & 0 deletions app/src/main/java/com/dscvit/vitty/ui/academics/AcademicsScreenContent.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,9 @@ fun AcademicsScreenContent(
alertDaysBefore,
attachmentUrl,
->
coursePageViewModel.setCourseId(selectedCourseForReminder!!.code)
coursePageViewModel.setCourseTitle(selectedCourseForReminder!!.title)

coursePageViewModel.addReminder(
title = title,
description = description,
Expand Down
1 change: 0 additions & 1 deletion app/src/main/java/com/dscvit/vitty/ui/academics/components/AcademicsScreenComponents.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,6 @@ fun CourseCard(
}
}

@RequiresApi(Build.VERSION_CODES.O)
@Composable
fun RemindersContent(
reminders: List<Reminder>,
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/java/com/dscvit/vitty/ui/connect/CircleMemberDetailScreenContent.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,7 @@ private fun DayScheduleContent(
) {
items(
items = periods,
key = { period -> "${period.courseCode}_${period.slot}" },
key = { period -> period.id },
) { period ->
CircleMemberPeriodCard(
period = period,
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/java/com/dscvit/vitty/ui/connect/FriendDetailScreenContent.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -772,7 +772,7 @@ private fun DayScheduleContent(
) {
items(
items = periods,
key = { period -> "${periods.indexOf(period)}${period.startTime}_${period.courseCode}_${period.slot}_${period.endTime}" },
key = { period -> period.id },
) { period ->
FriendPeriodCard(
period = period,
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/java/com/dscvit/vitty/ui/schedule/ScheduleScreenContent.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ private fun DayContent(
) {
items(
items = periods,
key = { period -> "${periods.indexOf(period)}${period.startTime}_${period.courseCode}_${period.slot}_${period.endTime}" },
key = { period -> period.id },
) { period ->
PeriodCard(
period = period,
Expand Down
Loading