Skip to content

Conversation

@JothishKamal
Copy link
Collaborator

@JothishKamal JothishKamal commented Aug 10, 2025

Pull Request Type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other

Purpose

  • WHAT is this PR for?
    Reorders the chips in ConnectScreenContent/Friends for better UX, refactors active friends list handling, improves Connect screen filters and messages, and cleans up code style.

Approach

  • HOW does this change fulfill the purpose?
    Active Friends List
  • Removed SharedPreferences usage for caching/updating active friends list
  • Now managed fully in memory for simpler state handling

Connect Screen

  • Swapped filter order: AllAvailable
  • Updated filter logic and empty state messages for better clarity

UI/UX + Code Style

  • Improved key for rendering period items in schedule
  • Minor formatting and readability improvements across MainComposeApp and related components

Issue Reference: #64 #63

Does this PR introduce any new bug?

  • Yes
  • No
  • Maybe

@JothishKamal JothishKamal requested a review from iamyajat as a code owner August 10, 2025 14:04
@dk-a-dev
Copy link
Contributor

Check existing issues as well!!

@JothishKamal JothishKamal changed the title feat: reorder filter options and adjust no friends messages in ConnectTabContent feat: reorder filter options and adjust no friends messages in ConnectTabContent + bug fixes Aug 10, 2025
@JothishKamal
Copy link
Collaborator Author

Check existing issues as well!!

Added fix for issues

Copy link
Contributor

@dk-a-dev dk-a-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dk-a-dev dk-a-dev merged commit 01476b0 into GDGVIT:v3 Aug 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants