[BUGFIX] Fix Philly (Train) Lights Not Working On Web #342
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
status: pending triage
Contributor
|
Classic shader moment |
Contributor
|
how was this only made now😭 looks like this has been happening since weekend 1 |
Member
|
Wow |
Hundrec
added
the
platform: html5
VirtuGuy
force-pushed
the
fix-philly-train-lights-not-working-on-web
branch
from
54f93cc to
e9f616d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On the web version of the game, Philly (Train)'s lights, or windows, do not show up. This is because
alphaShitis used in both the building shader class and the shader itself. What this PR does is it renames the class'salphaShitvariable so that there's no variable redefinition error on web.Screenshots/Videos
The error message you get when playing the game on Itch.io.
A screenshot of the lights working on web after I saved FNF and made it truly playable: