Skip to content

Conversation

@tritao
Copy link
Contributor

@tritao tritao commented Jun 28, 2025

Description

This adds a new aliasOf property to the emitted concrete type metadata in ABI.

Fixes #6564.

This is dependent in a following change in https://github.com/FuelLabs/fuel-abi-types.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@tritao tritao self-assigned this Jun 28, 2025
@tritao tritao added compiler General compiler. Should eventually become more specific as the issue is triaged ABI Everything to do the ABI, especially the JSON representation compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen labels Jun 28, 2025
@tritao tritao force-pushed the abi-aliased-types branch from 1a6a2fb to 5989ba2 Compare June 28, 2025 21:20
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 1, 2025

CodSpeed Performance Report

Merging #7261 will degrade performances by 10.91%

Comparing tritao:abi-aliased-types (4499642) with master (6b26e50)

Summary

❌ 1 regression
✅ 24 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
open_all_example_workspace_members 9.6 s 10.8 s -10.91%

@tritao tritao force-pushed the abi-aliased-types branch from f0d3478 to 66db5dc Compare October 14, 2025 14:50
@tritao tritao force-pushed the abi-aliased-types branch from 66db5dc to e565e43 Compare October 16, 2025 15:43
@tritao tritao force-pushed the abi-aliased-types branch from e565e43 to 75d1794 Compare October 18, 2025 13:33
@tritao tritao force-pushed the abi-aliased-types branch from 75d1794 to b7251ef Compare October 20, 2025 08:25
@tritao tritao force-pushed the abi-aliased-types branch from b7251ef to 909004a Compare October 20, 2025 08:27
@tritao tritao force-pushed the abi-aliased-types branch from 909004a to 3be6772 Compare October 26, 2025 22:15
@tritao tritao force-pushed the abi-aliased-types branch from 3be6772 to 4880b44 Compare October 26, 2025 22:16
@tritao tritao force-pushed the abi-aliased-types branch from 4880b44 to 136282a Compare November 2, 2025 22:11
@tritao tritao changed the title Improve processing of aliased types in ABI generation Add experimental ABI alias metadata support. Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ABI Everything to do the ABI, especially the JSON representation compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen compiler General compiler. Should eventually become more specific as the issue is triaged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Type alias name is missing in types

2 participants