Honda: update offline torque values for HONDA_CLARITY #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uto-tuned values for friction and lat accel factor 0.19 friction 0.96 lateral accel factor Updated selfdrive/car/torque_data/override.toml and params.toml
Owner
|
Thank you for your PR! If you're not already in the FrogPilot Discord, feel free to join and let me know you've opened a PR! |
FrogAi
force-pushed
the
MAKE-PRS-HERE
branch
2 times, most recently
from
397a612 to
fc98a63
Compare
Owner
|
I don't have access to that Discord channel. But I'd like to get the seal of approval from @mike8643 on this one as well. |
FrogAi
force-pushed
the
MAKE-PRS-HERE
branch
13 times, most recently
from
e585d6f to
676a58f
Compare
FrogAi
force-pushed
the
MAKE-PRS-HERE
branch
4 times, most recently
from
3237ce6 to
845ed86
Compare
FrogAi
force-pushed
the
MAKE-PRS-HERE
branch
7 times, most recently
from
9ddcd9b to
0a419a3
Compare
FrogAi
force-pushed
the
MAKE-PRS-HERE
branch
17 times, most recently
from
d4a7400 to
cc903bd
Compare
FrogAi
force-pushed
the
MAKE-PRS-HERE
branch
from
7d3c37b to
de73a4d
Compare
FrogAi
force-pushed
the
MAKE-PRS-HERE
branch
7 times, most recently
from
0823b67 to
9f4a801
Compare
FrogAi
force-pushed
the
MAKE-PRS-HERE
branch
5 times, most recently
from
43ac771 to
1322986
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used manual tuning with torqued auto-tune to arrive at following values for Honda Clarity:
0.19 friction
0.96 lateral accel factor
Original values found in params.toml were a copy of HONDA_CIVIC (https://github.com/vanillagorillaa/openpilot/blob/731ed143281bb116d8fdd45a6999767df3a0f235/selfdrive/car/torque_data/params.yaml#L18)
Explanation from VG on why he copied HONDA_CIVIC values: https://discord.com/channels/582748902588153856/582748902588153858/1409525875405230201
Removed Clarity entry from params.toml and added Clarity entry in override.toml