Open
Conversation
merge fof/merge-discussions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Case
merging by date
discussion to which you want to merge is not in time order (e.g. you merge two discussion by append)
and at least one post was deleted (so count != max number)
posts:
post | created at | number | new number
P1 | 2020-01-01 | 1 | 2
P2 | 2019-01-01 | 3 | 1
fixPostsNumber will failed on updating P2 with new number 1
Changes proposed in this pull request:
first "renumber" start with max number
then "renumber" start with 0