Skip to content

fix(libraries): prevent dangling reference in ely libs override #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
notwindstone merged 1 commit into from
Apr 13, 2025
Merged

fix(libraries): prevent dangling reference in ely libs override #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions launcher/minecraft/launch/ApplyLibraryOverrides.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ void ApplyLibraryOverrides::onLibraryOverrideDownloadFinished()
continue;
}

auto versionRef = artifactRef.toObject()[library->version()];
if (!versionRef.isObject()) {
auto version = artifactRef.toObject().value(library->version());
if (!version.isObject()) {
continue;
}

Expand All @@ -67,7 +67,7 @@ void ApplyLibraryOverrides::onLibraryOverrideDownloadFinished()
continue;
}

auto override = versionRef.toObject();
auto override = version.toObject();
auto newDownloadInfo = std::make_shared<MojangDownloadInfo>();
newDownloadInfo->url = override["url"].toString();
newDownloadInfo->sha1 = override["sha1"].toString();
Expand Down
Loading