Quickpi useless blocks #76
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doc adding
[QuickPi][Fr] Changed french block of fill
…s a public function of the context
…ent than their name in documentation)
mblockelet
requested changes
Jan 8, 2021
Contributor
mblockelet
left a comment
mblockelet
left a comment
There was a problem hiding this comment.
Generally good changes, I just made a few comments which are mostly about making the code more generic (some parts are too specific to quick-pi) and also slightly simpler.
| // Some data can be made accessible by the library through the context object | ||
| context.quickpi = {}; | ||
|
|
||
| // we put that outside of the function #context.getConceptList because that is our only way to know the which sensor |
Contributor
There was a problem hiding this comment.
I don't understand why you took the list out ; you could just call context.getConceptList();.
Collaborator
Author
There was a problem hiding this comment.
I done this to prevent calls to getConceptList because I just need the fields that I have put outside.
This reverts commit 8afadf0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aim is to remove blocks that can't be used:
A block "that can't be used", is a block that the sensor for it has been deleted. For example if you remove all the leds, then all the blocks that use led are deleted (in blockly and python).
We also needed to handle the case when the block is already in use in user's code. In that case:
In python
In python it was already handled: it says an error during execution saying that the function does not exists.
In blockly
In blockly, there is a message saying that the highlighted block is not allowed at the start of the execution.
This pull request also modify the message during the deletion of a sensor to say to the user that he has to remove all functions that use this sensor in his code.