nb_smu_ops: clean up and deduplicate values #377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlyGoat
reviewed
Sep 22, 2025
| FAM_END | ||
| }; | ||
| FAM_FIRERANGE | ||
| } RYZEN_FAMILY; |
Owner
There was a problem hiding this comment.
Hmm, this would break existing API users, what's your intension here?
Contributor
Author
There was a problem hiding this comment.
slowly PR my rewrite, keeping the ryzen obj public as discussed in #314 , or i can just open a single pr if you prefer? (probably also easier for me)
there will be breaking changes, maybe major version bump? and also winring is now flagged as trojan so that is another breaking change that will happen as soon as i find a viable alternative, unless you want to keep it here? i will remove it in my fork
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trying to slowly reduce diff with my fork so it is easier to review