Open
Conversation
daniellienert
changed the title
daniellienert
changed the title
daniellienert
force-pushed
the
feature/use-tus-for-upload-on-separate-endpoint
branch
from
41afe25 to
2ee5eb9
Compare
- Make maximumUploadChunkSize configurable
Sebobo
reviewed
Nov 11, 2021
daniellienert
changed the title
Sebobo
reviewed
Jan 24, 2022
| * source code. | ||
| */ | ||
|
|
||
| use Carbon\Carbon; |
Member
There was a problem hiding this comment.
This dependency doesn't seem to be included in the composer.json. Maybe we can get rid of this and replace the one method used?
Sebobo
reviewed
Jan 24, 2022
| */ | ||
| public function getTtl(): int | ||
| { | ||
| return 60*60*24; |
Sebobo
reviewed
Jan 24, 2022
| uploadFiles(files) | ||
| .then(() => { | ||
| Notify.ok(translate('uploadDialog.uploadFinished', 'Upload finished')); | ||
| refetchAssets(); |
Member
There was a problem hiding this comment.
Is there any replacement for the call to refetch the assets?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature adds file upload via TUS (https://tus.io/) protocol. This brings the following advantages:
To discuss:
TUS.Upload.1.mov
Resolves: #61