-
Notifications
You must be signed in to change notification settings - Fork 82
Replace kebab menu with headless UI #6489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cstns
wants to merge
8
commits into
teleported-menus-alignment
Choose a base branch
from
6374_kebab-menu-headless-ui
base: teleported-menus-alignment
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enu API for improved structure and functionality.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## teleported-menus-alignment #6489 +/- ##
===========================================================
Coverage 76.42% 76.42%
===========================================================
Files 396 396
Lines 19885 19885
Branches 4766 4766
===========================================================
Hits 15198 15198
Misses 4687 4687
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…proved clarity and structure.
…nu for alignment with updated mixin structure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace the kebab menu to use the headless ui menu and align with the rest of headless ui components usage instead of the bespoke collision detection.
I had to alter some e2e tests that were relying on a double click in order to open the menu, in that i remove the 2nd click because it was not correctly causing the kebab menu to close.
Also had to alter the ListItem unit test to properly test the headless ui component.
Related Issue(s)
part of #6374
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel