Teleported menus alignment #6488
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve menu positioning and state synchronization logic.
…nents and refine position re-calculations for overflow handling.
…listbox, and combobox components, and simplify position re-calculations.
…nu positioning logic.
… ComboBox components.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6488 +/- ##
=======================================
Coverage 76.42% 76.42%
=======================================
Files 396 396
Lines 19885 19885
Branches 4766 4766
=======================================
Hits 15198 15198
Misses 4687 4687
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ponents for consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tidying up after the expert release before the holidays where it was found that menu items that were teleported to the body of the page either overflowed outside the viewport or had their widths impacted.
Menu width and positioning is measured and adjusted in a cohesive manner across components.
This PR improves overflow detection and collision detection and fixes menu widths while serving a starting point for the following work on the kebab menu.
As a quick fix, I also addressed the teleports in these components and correctly placed them in the teleported slot so they produce their effects.
Related Issue(s)
pre-requisite for #6374
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel