Skip to content

Conversation

@cstns
Copy link
Contributor

@cstns cstns commented Jan 9, 2026

Description

Fixes the ToggleButtonGroup width to make room for the indicator right border:
Before:
image
After:
image

The ToggleButtonGroup was not identifying the correct selectedIndex because it was receiving a relative path as a prop from the VersionHistory page when running in immersive mode. We relied on the router-link component to handle the active class until recently and it didn't pose a problem.

Switching to named paths in the VersionHistory when setting the pageToggle props on the ToggleButtonGroup fixes the problem.

Related Issue(s)

N/A

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • Includes a DB migration? -> add the area:migration label

@cstns cstns requested a review from dimitrieh January 9, 2026 16:21
@cstns cstns self-assigned this Jan 9, 2026
@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.42%. Comparing base (bff39e1) to head (2ede54a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6487   +/-   ##
=======================================
  Coverage   76.42%   76.42%           
=======================================
  Files         396      396           
  Lines       19885    19885           
  Branches     4766     4766           
=======================================
  Hits        15198    15198           
  Misses       4687     4687           
Flag Coverage Δ
backend 76.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@dimitrieh dimitrieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

One remaining artifact though we can be solved separately. This has to do with licensing/feature enabled or not afaik

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants