Make immersive editor drawer have pin/unpin and more responsive to browser sizes/resizing #6318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ionality Enhance the immersive editor drawer with advanced features matching the Expert drawer: - Add pin/unpin button with dual-mode behavior (overlay vs pinned) - Implement advanced responsive behavior with viewport-aware constraints - Add smooth animations for pinning, opening, and closing states - Improve manual resize with viewport-specific max-width constraints - Provide togglePinWithWidth and shouldAllowPinning to child components - Auto-unpin drawer when viewport shrinks below 768px threshold - Different max-width constraints: - Pinned mode: 50% of viewport - Overlay mode (≥768px): 90% viewport OR viewport - 200px margin - Overlay mode (480-767px): 90% viewport only - Mobile (<480px): 100% viewport width Technical changes: - Change EditorWrapper from position:absolute to flex:1 for proper flex layout - Reorder DOM elements (drawer before editor) for correct flex positioning - Add animation state flags (isPinning, isOpening, isClosing) - Implement debounced viewport resize handler with constraint enforcement - Add pin button styling with active state (indigo background when pinned) When drawer is pinned, it becomes part of the flex layout and pushes the iframe editor to the right, allowing both to be visible side-by-side.
Contributor
Author
|
@cstns quick try:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6318 +/- ##
=======================================
Coverage 76.22% 76.22%
=======================================
Files 393 393
Lines 19777 19777
Branches 4741 4741
=======================================
Hits 15075 15075
Misses 4702 4702
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
…ionality
Enhance the immersive editor drawer with advanced features matching the Expert drawer:
Technical changes:
When drawer is pinned, it becomes part of the flex layout and pushes the iframe editor to the right, allowing both to be visible side-by-side.
Related Issue(s)
#6267
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel