Skip to content

Conversation

@hardillb
Copy link
Contributor

@hardillb hardillb commented Apr 15, 2025

closes #376

Description

If configured with the 3 word phrase the agent will ask if you want to start it

Also added new -s flag which suppresses the question if included

Related Issue(s)

#376

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb self-assigned this Apr 15, 2025
@hardillb hardillb requested a review from Steve-Mcl April 15, 2025 13:34
@hardillb
Copy link
Contributor Author

@joepavitt I've tagged Steve to review, but as he's not back till Tuesday, feel free to nominate somebody else

@joepavitt joepavitt requested review from Copilot and knolleary April 15, 2025 13:51
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • package.json: Language not supported
Comments suppressed due to low confidence (2)

index.js:133

  • The property 'otc' is being removed, yet the new flag is 'otc-dont-start'. Please verify that 'options.otc' is intended for clean-up and that this deletion does not conflict with the new naming conventions.
delete options.otc

index.js:153

  • Ensure that the call to start(options, configFound) does not result in a duplicate invocation of the start function, especially after handling the interactive branch. A clear control flow separation between interactive and non-interactive paths would improve reliability.
start(options, configFound)

@joepavitt
Copy link
Contributor

@knolleary something you can look over in Steve's absence please?

Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pulled, tested, and after change to supported package - good to go.

@Steve-Mcl Steve-Mcl merged commit 09fb374 into main Apr 17, 2025
4 checks passed
@Steve-Mcl Steve-Mcl deleted the start-on-config branch April 17, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add prompt for Device Agent setup

4 participants