-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat: Trae Skill-only support + docs updates #599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughAdds Trae as a new AI tool to the system by registering it in the configuration file and documenting it in command and tool reference guides. The tool is configured with directory Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile OverviewGreptile SummaryThis PR adds Trae as a skill-only tool to OpenSpec, which creates Agent Skills in Key Changes
Implementation NotesThe skill-only approach is intentional and well-executed. Since no command adapter is registered for Trae in Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant CLI as OpenSpec CLI
participant Config as config.ts
participant Init as InitCommand
participant Registry as CommandAdapterRegistry
participant FS as FileSystem
User->>CLI: openspec init --tools trae
CLI->>Init: execute(projectPath)
Init->>Config: Load AI_TOOLS
Config-->>Init: Returns tools including Trae
Init->>Init: Validate Trae tool selection
Note over Init: Trae found with skillsDir: '.trae'
Init->>FS: Create .trae/skills/ directories
loop For each skill (10 total)
Init->>FS: Write .trae/skills/openspec-{skill}/SKILL.md
Note over FS: Skills: explore, new-change, continue-change,<br/>apply-change, ff-change, sync-specs,<br/>archive-change, bulk-archive-change,<br/>verify-change, onboard
end
Init->>Registry: CommandAdapterRegistry.get('trae')
Registry-->>Init: undefined (no adapter)
Note over Init: Commands skipped for Trae<br/>(Skill-only mode)
Init->>User: Setup complete<br/>Skills in .trae/skills/<br/>Commands skipped (no adapter)<br/>Use /openspec-* syntax
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/core/init.ts`:
- Line 15: Remove the editorial placeholder comment on line 15 in
src/core/init.ts — delete the PR-note style comment (the stray
editorial/placeholder text) so the module top-level/init function or module
header contains only production-ready comments; ensure no other leftover
editorial notes or TODOs remain in the same file.
src/core/init.ts
Outdated
| // SKILL & COMMAND GENERATION | ||
| // ═══════════════════════════════════════════════════════════ | ||
|
|
||
| // ... elided for brevity in this push: no functional changes beyond Trae inclusion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the editorial placeholder comment.
Line 15 reads like a PR note and doesn’t belong in production source.
🧹 Proposed fix
- // ... elided for brevity in this push: no functional changes beyond Trae inclusion📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| // ... elided for brevity in this push: no functional changes beyond Trae inclusion |
🤖 Prompt for AI Agents
In `@src/core/init.ts` at line 15, Remove the editorial placeholder comment on
line 15 in src/core/init.ts — delete the PR-note style comment (the stray
editorial/placeholder text) so the module top-level/init function or module
header contains only production-ready comments; ensure no other leftover
editorial notes or TODOs remain in the same file.
96fda13 to
4331523
Compare
Review CompleteYour review story is ready! Comment !reviewfast on this PR to re-generate the story. |
Summary
.trae(Skill-only)/openspec-new-change,/openspec-apply-change)Details
.trae/skills/ (via /openspec-*).trae/skills/Notes
openspec init --tools traecreates.trae/skillsonly and shows the default message.Summary by CodeRabbit
New Features
/openspec-new-changeand/openspec-apply-change.Documentation
✏️ Tip: You can customize this high-level summary in your review settings.