Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
synapse-dev | 1bb222f | Commit Preview URL Branch Preview URL |
Feb 27 2026, 08:24 PM |
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
snissn
left a comment
There was a problem hiding this comment.
Deep-dive review complete. I found and fixed a set of docs API-drift issues in follow-up PR #629 (https://github.com/FilOzone/synapse-sdk/pull/629):\n\n- React guide examples now handle optional wallet address correctly under strict TS settings\n- Storage Context guide examples updated to current options-object download API and valid upload input types\n- Synapse and Synapse Core signatures/examples corrected for current SDK behavior\n\nMergeability status: #628 is CLEAN against master.\n\nRecommendation: once #629 is incorporated into this branch/work (via merge/cherry-pick/rebase), I approve this docs refresh for merge. Without those fixes, I recommend holding merge due to misleading example usage in key developer guides.
|
#630 also adds session key docs so it could also be reviewed along with this for fit |
|
All the fixes mentioned above have been applied. In addition, I've:
I'd recommend we merge this as soon as possible builders are already midway through the 30-day hackathon and need up-to-date docs. cc: @BigLep |
Refreshes developer guide documentation to reflect all synapse packages.
@filoz/synapse-reacthooks@filoz/synapse-coremodules usage examples