Skip to content

Fix invalid v/* glob example — replace with v* throughout #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
redpanda-f merged 2 commits into from
Mar 11, 2026
Merged

Fix invalid v/* glob example — replace with v* throughout #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f858714
Initial plan
Copilot Mar 11, 2026
44291f0
Replace invalid v/* glob pattern with v* in docs and code
Copilot Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README_ADVANCED.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ foc-devnet init [OPTIONS]

**Source Format:**
- `latesttag` - Newest git tag in the default repo (resolved once at `init`).
- `latesttag:<selector>` - Newest git tag matching a glob selector, e.g. `latesttag:v/*` or `latesttag:pdp/v*`.
- `latesttag:<url>:<selector>` - Newest matching tag from a custom repo, e.g. `latesttag:https://github.com/org/repo.git:v/*`.
- `latesttag:<selector>` - Newest git tag matching a glob selector, e.g. `latesttag:v*` or `latesttag:pdp/v*`.
- `latesttag:<url>:<selector>` - Newest matching tag from a custom repo, e.g. `latesttag:https://github.com/org/repo.git:v*`.
- `gittag:<tag>` - Specific git tag (uses default repo)
- `gittag:<url>:<tag>` - Tag from custom repo, e.g. `gittag:https://github.com/org/repo.git:v1.0.0`
- `gitcommit:<sha>` - Specific commit (uses default repo)
Expand Down Expand Up @@ -817,7 +817,7 @@ port_range_count = 100
Default versions for these repositories are defined in code (see [`src/config.rs`](src/config.rs) `Config::default()`).

**Version specification methods:**
- **Latest tag** (`latesttag`, `latesttag:<selector>`, `latesttag:<url>:<selector>`): Resolved once at `init` time via `git ls-remote` and pinned as a concrete `GitTag` in `config.toml`. Use a glob selector to scope which tags are considered, e.g. `latesttag:v/*` or `latesttag:pdp/v*`. Bare `latesttag` matches all tags.
- **Latest tag** (`latesttag`, `latesttag:<selector>`, `latesttag:<url>:<selector>`): Resolved once at `init` time via `git ls-remote` and pinned as a concrete `GitTag` in `config.toml`. Use a glob selector to scope which tags are considered, e.g. `latesttag:v*` or `latesttag:pdp/v*`. Bare `latesttag` matches all tags.
- **Git tags** (`GitTag`): Used for stable releases. Tags provide version pinning and stability.
- **Git commits** (`GitCommit`): Used for repositories where specific commits are required and there isn't a corresponding tag yet. (Generally tags should be preferred over commits.)
- **Git branches** (`GitBranch`): Used for development or when tracking latest changes.
Expand Down
6 changes: 3 additions & 3 deletions src/cli.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,15 @@ pub enum Commands {
#[arg(long)]
curio: Option<String>,
/// Lotus source location.
/// Latest tag: 'latesttag' (newest), 'latesttag:<selector>' (e.g. 'latesttag:v/*'),
/// Latest tag: 'latesttag' (newest), 'latesttag:<selector>' (e.g. 'latesttag:v*'),
/// 'latesttag:<url>:<selector>' (custom repo). Resolved once at init.
/// Explicit: 'gittag:<tag>', 'gittag:<url>:<tag>', 'gitcommit:<sha>',
/// 'gitcommit:<url>:<sha>', 'gitbranch:<branch>', 'gitbranch:<url>:<branch>',
/// 'local:/path/to/lotus'.
#[arg(long)]
lotus: Option<String>,
/// Filecoin Services source location.
/// Latest tag: 'latesttag' (newest), 'latesttag:<selector>' (e.g. 'latesttag:v/*'),
/// Latest tag: 'latesttag' (newest), 'latesttag:<selector>' (e.g. 'latesttag:v*'),
/// 'latesttag:<url>:<selector>' (custom repo). Resolved once at init.
/// Explicit: 'gittag:<tag>', 'gittag:<url>:<tag>', 'gitcommit:<sha>',
/// 'gitcommit:<url>:<sha>', 'gitbranch:<branch>', 'gitbranch:<url>:<branch>',
Expand Down Expand Up @@ -97,7 +97,7 @@ pub enum BuildCommands {
pub enum ConfigCommands {
/// Configure Lotus source location
Lotus {
/// Lotus source location (e.g., 'latesttag', 'latesttag:v/*', 'latesttag:<url>:v/*', 'gittag:v1.0.0', 'gitcommit:abc123', 'gitbranch:main', 'local:/path/to/lotus')
/// Lotus source location (e.g., 'latesttag', 'latesttag:v*', 'latesttag:<url>:v*', 'gittag:v1.0.0', 'gitcommit:abc123', 'gitbranch:main', 'local:/path/to/lotus')
source: String,
},
/// Configure Curio source location
Expand Down
2 changes: 1 addition & 1 deletion src/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,7 @@ mod tests {
#[test]
fn latesttag_with_url() {
assert_eq!(
canonicalize("latesttag:https://github.com/randomorg/randomrepo:v/*").unwrap(),
canonicalize("latesttag:https://github.com/randomorg/randomrepo:v*").unwrap(),
(
"gittag".into(),
"https://github.com/randomorg/randomrepo".into(),
Expand Down