Skip to content

[WIP] Fix FALKORDB_PORT default type inconsistency across modules#647

Draft
Claude wants to merge 1 commit intostagingfrom
claude/fix-falkordb-port-inconsistency
Draft

[WIP] Fix FALKORDB_PORT default type inconsistency across modules#647
Claude wants to merge 1 commit intostagingfrom
claude/fix-falkordb-port-inconsistency

Conversation

@Claude
Copy link
Copy Markdown

@Claude Claude AI commented Apr 10, 2026

Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.


This section details on the original issue you should resolve

<issue_title>Bug: FALKORDB_PORT default type inconsistency across modules</issue_title>
<issue_description>## Description

FALKORDB_PORT is retrieved with inconsistent default types across modules:

Integer default (5 locations):

# api/graph.py, api/git_utils/git_graph.py, api/llm.py
port=os.getenv('FALKORDB_PORT', 6379)  # default is int

String default with explicit cast (1 location):

# api/info.py
port=int(os.getenv('FALKORDB_PORT', "6379"))  # default is str, explicitly cast

os.getenv() always returns a string when the var is set. When it's not set, the default 6379 (int) is passed directly to the port parameter. Depending on how the FalkorDB client handles the port parameter, this may work by accident or fail silently.

Suggested Fix

Consistently use:

port=int(os.getenv('FALKORDB_PORT', '6379'))

Or better yet, centralize configuration in a single place.

Context

Found during code review of PR #522.</issue_description>

Comments on the Issue (you are @claude[agent] in this section)

@Claude Claude AI linked an issue Apr 10, 2026 that may be closed by this pull request
Copilot stopped work on behalf of DvirDukhan due to an error April 10, 2026 06:59
@Claude Claude AI requested a review from DvirDukhan April 10, 2026 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: FALKORDB_PORT default type inconsistency across modules

2 participants