Skip to content

Improve logging archive#9940

Closed
766974616c79 wants to merge 1 commit intoFacepunch:masterfrom
766974616c79:master
Closed

Improve logging archive#9940
766974616c79 wants to merge 1 commit intoFacepunch:masterfrom
766974616c79:master

Conversation

@766974616c79
Copy link
Contributor

Summary

This PR:

  • changes the archive format
  • archives every day
  • archives when logs exceed 512 MB
  • compresses archives

Motivation & Context

Fixes: #226

Checklist

  • Code follows existing style and conventions
  • No unnecessary formatting or unrelated changes
  • Public APIs are documented (if applicable)
  • Unit tests added where applicable and all passing
  • I’m okay with this PR being rejected or requested to change 🙂

Copilot AI review requested due to automatic review settings January 31, 2026 04:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the NLog file-target configuration to prevent runaway log growth (issue #226) by introducing daily and size-based archiving with compression.

Changes:

  • Configure NLog FileTarget to archive logs daily and when exceeding ~512 MB.
  • Switch archive output to compressed .zip files using a date-based archive naming scheme.
  • Add NLog.Targets usage to access FileArchivePeriod.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@handsomematt handsomematt added the triaged triaged pull-requests are replicated on the internal sbox repo label Feb 2, 2026
@sboxbot sboxbot added the accepted this pull request was accepted, hurrah! label Feb 2, 2026
@sboxbot
Copy link
Contributor

sboxbot commented Feb 2, 2026

This PR has been merged upstream.

@sboxbot sboxbot closed this Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted this pull request was accepted, hurrah! triaged triaged pull-requests are replicated on the internal sbox repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Log files getting too large

3 participants