-
Notifications
You must be signed in to change notification settings - Fork 0
Make HoodIOInputs fields public to match IO pattern #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: GrumpyBud <[email protected]>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Aligns HoodIOInputs with the established AdvantageKit @AutoLog IO pattern used across the robot codebase by making its input fields public, consistent with other *IOInputs types.
Changes:
- Changed all
HoodIOInputsfields from package-private topublicto match other@AutoLoginput containers.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The
HoodIOInputsclass had package-private fields, inconsistent with all other*IOInputsclasses which usepublicfields for AdvantageKit's@AutoLogannotation.Changes
publicmodifier to all fields inHoodIOInputsNow matches the pattern in
FlywheelIOInputs,ModuleIOInputs,SpindexerIOInputs, andKickerIOInputs.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.