Add invoicing to bookOrManageTravel instead of rendering it as a page #81761

stitesExpensify · 2026-02-06T21:46:32Z

Explanation of Change

https://expensify.slack.com/archives/C9YU7BX5M/p1770402758104859
We were displaying the invoicing section of travel as the entire travel page for users who are on the beta (all of expensify and applause). This resulted in travel being unusable and untestable.

To fix this, I changed the invoicing section to only return the section, and added that to the regular travel page behind a beta.

Fixed Issues

$#81603
PROPOSAL: n/a

Tests

Log into an account with travel enabled
Go to the workspace travel settings page
Ensure that you see the new booking page and the invoicing toggle
Click the book or manage link and ensure that you are brought to staging (even though it won't work)

Verify that no errors appear in the JS console

Offline tests

n/a

QA Steps

Existing account on beta

Log into an account that has travel enabled
Go to the workspace travel settings page
Ensure that you see the new booking page and the invoicing toggle
Click the book or manage link and ensure that you are brought to staging

Existing account not on beta

Log into an account that has travel enabled but is not on the beta (AKA a gmail)
Go to the workspace travel settings page
Ensure that you see the new booking page and you do not see the invoicing toggle
Click the book or manage link and ensure that you are brought to staging

New account

Run through the regression tests for a new travel account
Ensure that you see the new booking page with the invoicing toggle

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-02-06T21:58:41Z

@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-02-06T21:58:46Z

@huult Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2d00f9c7dd

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/pages/workspace/travel/BookOrManageYourTrip.tsx

codecov · 2026-02-06T22:22:30Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/pages/workspace/travel/PolicyTravelPage.tsx	`0.00% <ø> (ø)`
...rkspace/travel/WorkspaceTravelInvoicingSection.tsx	`66.66% <100.00%> (-8.34%)`	⬇️
...rc/pages/workspace/travel/BookOrManageYourTrip.tsx	`0.00% <0.00%> (ø)`
... and 12 files with indirect coverage changes

stitesExpensify · 2026-02-06T22:41:33Z

Code coverage has decreased because we removed some of the actual page elements

stitesExpensify · 2026-02-06T22:48:58Z

src/pages/workspace/travel/BookOrManageYourTrip.tsx

+    const handleManageTravel = () => {
+        // TODO: Show the prevention modal when the beta is enabled
+        if (isPreventSpotnanaTravelEnabled) {
+            return;


The user won't get any UI feedback in this case which is a bad UX, but this is an edge case for admins who are trying to book from here for some reason when they have specifically asked to have travel disabled. I'll improve this later

Follow-up #81764

blimpich · 2026-02-06T22:53:07Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

blimpich

Approving without C+ review because we know that the travel page has a setting for editing prepending descriptions on expenses that is really needed by a angry customer, so we want to get this in quickly.

blimpich · 2026-02-06T23:01:07Z

Assigning new reviewers based off this conversation: https://expensify.slack.com/archives/C05S5EV2JTX/p1770418816265019?thread_ts=1770415610.786929&cid=C05S5EV2JTX

parasharrajat · 2026-02-08T13:51:08Z

Screenshots

parasharrajat · 2026-02-08T14:41:52Z

BUG: Link does not work in iOS.

08.02.2026_20.10.55_REC.mp4

stitesExpensify · 2026-02-09T15:27:26Z

@parasharrajat what email were you using for that testing? I'll try to look at the logs and see what is happening

…voicingPage

stitesExpensify · 2026-02-10T00:25:22Z

@parasharrajat I am not able to reproduce (Ignore that I'm missing all images)

2026-02-09_19-25-13.mp4

stitesExpensify added 4 commits February 6, 2026 16:43

Switch from an image and featureList to section

a6c1cd8

render invoicing section individually

c458af2

Only display the section not the rest of the travel page

b03b3b0

Stop rendering the section as a page

4d76acb

stitesExpensify self-assigned this Feb 6, 2026

stitesExpensify added 3 commits February 6, 2026 16:53

Prettier

f91f16f

Remove unused imports/vars

44c6aec

Remove unused import

2d00f9c

stitesExpensify marked this pull request as ready for review February 6, 2026 21:58

stitesExpensify requested review from a team as code owners February 6, 2026 21:58

melvin-bot bot requested review from a team and bernhardoj and removed request for a team February 6, 2026 21:58

melvin-bot bot requested review from heyjennahay and huult and removed request for a team February 6, 2026 21:58

melvin-bot bot removed the request for review from a team February 6, 2026 21:58

stitesExpensify requested a review from blimpich February 6, 2026 22:02

chatgpt-codex-connector bot reviewed Feb 6, 2026

View reviewed changes

src/pages/workspace/travel/BookOrManageYourTrip.tsx Show resolved Hide resolved

Fix test

cd736ab

Prevent booking if the company has decided to prevent it

0073947

stitesExpensify commented Feb 6, 2026

View reviewed changes

blimpich previously approved these changes Feb 6, 2026

View reviewed changes

blimpich removed the request for review from bernhardoj February 6, 2026 23:00

blimpich requested review from ikevin127 and parasharrajat and removed request for heyjennahay and huult February 6, 2026 23:00

Merge branch 'main' of github.com:Expensify/App into stites-combineIn…

9eb91c1

…voicingPage

stitesExpensify dismissed blimpich’s stale review via 9eb91c1 February 9, 2026 16:47

stitesExpensify added 2 commits February 9, 2026 18:07

Merge branch 'main' of github.com:Expensify/App into stites-combineIn…

2d5785a

…voicingPage

Merge branch 'main' of github.com:Expensify/App into stites-combineIn…

db51fb7

…voicingPage

Add invoicing to bookOrManageTravel instead of rendering it as a page #81761

Are you sure you want to change the base?

Add invoicing to bookOrManageTravel instead of rendering it as a page #81761

Conversation

stitesExpensify commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

Existing account on beta

Existing account not on beta

New account

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 6, 2026

Uh oh!

melvin-bot bot commented Feb 6, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

codecov bot commented Feb 6, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

stitesExpensify commented Feb 6, 2026

Uh oh!

stitesExpensify Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

stitesExpensify Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

blimpich commented Feb 6, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

blimpich left a comment

Choose a reason for hiding this comment

Uh oh!

blimpich commented Feb 6, 2026

Uh oh!

parasharrajat commented Feb 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Screenshots

Uh oh!

parasharrajat commented Feb 8, 2026

Uh oh!

stitesExpensify commented Feb 9, 2026

Uh oh!

stitesExpensify commented Feb 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

stitesExpensify commented Feb 6, 2026 •

edited

Loading

codecov bot commented Feb 6, 2026 •

edited by github-actions bot

Loading

parasharrajat commented Feb 8, 2026 •

edited

Loading