Skip to content

Fix iOS multi-level tags text overlap in WorkspaceTagsPage#81738

Open
MobileMage wants to merge 6 commits intoExpensify:mainfrom
MobileMage:fix/81022-ios-tags-text-overlap
Open

Fix iOS multi-level tags text overlap in WorkspaceTagsPage#81738
MobileMage wants to merge 6 commits intoExpensify:mainfrom
MobileMage:fix/81022-ios-tags-text-overlap

Conversation

@MobileMage
Copy link
Contributor

@MobileMage MobileMage commented Feb 6, 2026

Explanation of Change

Moved the RenderHTML block out of the Text component and made them siblings instead of parent-child. On iOS, nesting a View (containing RenderHTML with block-level content model) inside a Text component causes React Native to miscalculate layout, resulting in overlapping text. This matches how RenderHTML is used everywhere else in the codebase (e.g. ShortTermsForm.tsx, EmailDeliveryFailurePage.tsx, TravelTerms.tsx), where View + RenderHTML is always a sibling to Text, never a child.

Fixed Issues

$ #81022
PROPOSAL: #81022 (comment)

Tests

  1. Be an admin of a workspace with Tags enabled
  2. Navigate to workspace settings > Tags
  3. Click "More" > "Import spreadsheet"
  4. Click "Multi-level tags" > "Import tags"
  5. Upgrade the workspace if a paywall is displayed (to a Control plan)
  6. Upload a dependent multi-level tags CSV file
  7. Ensure "These are independent tags" is DISABLED
  8. Click "Import" and then "Got it" on the success modal
  9. Verify the informational text ("Tags add more detailed ways to classify costs." and "You are using dependent tags...") is readable, fully visible, and not overlapping under the "More" dropdown
  • Verify that no errors appear in the JS console

Offline tests

N/A - This is an iOS layout fix that does not involve network requests.

QA Steps

Same as tests (on iOS device/simulator).

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native simulator_screenshot_2940BE47-A420-409A-95FD-3CA4E0263B37
iOS: mWeb Safari
MacOS: Chrome / Safari

@MobileMage
Fix iOS multi-level tags text overlap in WorkspaceTagsPage
5b5afbd 
Move RenderHTML block out of Text component and make them siblings.
On iOS, nesting a View (containing RenderHTML with block-level content)
inside a Text component causes layout miscalculation and overlapping text.

Fixes Expensify#81022
@MobileMage MobileMage requested review from a team as code owners February 6, 2026 19:06
@melvin-bot
Copy link

melvin-bot bot commented Feb 6, 2026

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed request for a team February 6, 2026 19:06
@codecov
Copy link

codecov bot commented Feb 6, 2026 •
edited by github-actions bot
Loading

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/components/RenderHTML.tsx 100.00% <100.00%> (ø)
src/pages/workspace/tags/WorkspaceTagsPage.tsx 47.36% <75.00%> (ø)
... and 379 files with indirect coverage changes

@parasharrajat
Copy link
Member

parasharrajat commented Feb 6, 2026

let's update the RenderHTML component as well to throw an error if rendered in a inline nodes..

Can you do this?

@MobileMage MobileMage force-pushed the fix/81022-ios-tags-text-overlap branch from bf1df60 to 5b5afbd Compare February 6, 2026 21:10
@parasharrajat
Copy link
Member

parasharrajat commented Feb 6, 2026

We should add a test to validate that an error is throw when renderHTML is rendered inside Text.

@MobileMage
Add test for RenderHTML Text ancestor guard
f0660df
@MobileMage
Fix ESLint errors in RenderHTMLTest
d1641d7
@MobileMage
Merge branch 'main' of https://github.com/Expensify/App into fix/8102…
3a6b67f 
…2-ios-tags-text-overlap
@MobileMage
Use platform-specific hook for TextAncestor check
498d1e1 
unstable_TextAncestorContext is not available in react-native-web,
so use a platform-specific useHasTextAncestor hook instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parasharrajat parasharrajat Awaiting requested review from parasharrajat

@heyjennahay heyjennahay Awaiting requested review from heyjennahay

At least 1 approving review is required to merge this pull request.

Assignees

@MobileMage MobileMage

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MobileMage @parasharrajat